From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] carl9170: remove unneeded NULL check
Date: Sun, 2 Dec 2012 13:42:38 +0300 [thread overview]
Message-ID: <20121202104238.GB16078@elgon.mountain> (raw)
The "sta" variable is not checked for NULL consistently and it makes the
static checkers complain. I asked Christian Lamparter about this and
it turns out the check is not needed. "In fact, in order to set up a
ampdu session, the stack would call the driver's op_ampdu_action
callback which always needs a station."
I have removed the check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/ath/carl9170/tx.c b/drivers/net/wireless/ath/carl9170/tx.c
index 84377cf..23d33c3 100644
--- a/drivers/net/wireless/ath/carl9170/tx.c
+++ b/drivers/net/wireless/ath/carl9170/tx.c
@@ -1463,6 +1463,7 @@ void carl9170_op_tx(struct ieee80211_hw *hw,
struct ar9170 *ar = hw->priv;
struct ieee80211_tx_info *info;
struct ieee80211_sta *sta = control->sta;
+ struct carl9170_sta_info *stai;
bool run;
if (unlikely(!IS_STARTED(ar)))
@@ -1479,10 +1480,8 @@ void carl9170_op_tx(struct ieee80211_hw *hw,
* all ressouces which are associated with the frame.
*/
- if (sta) {
- struct carl9170_sta_info *stai = (void *) sta->drv_priv;
- atomic_inc(&stai->pending_frames);
- }
+ stai = (void *) sta->drv_priv;
+ atomic_inc(&stai->pending_frames);
if (info->flags & IEEE80211_TX_CTL_AMPDU) {
run = carl9170_tx_ampdu_queue(ar, sta, skb);
next reply other threads:[~2012-12-02 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 10:42 Dan Carpenter [this message]
2012-12-02 13:49 ` [patch] carl9170: remove unneeded NULL check Christian Lamparter
2012-12-02 16:51 ` Dan Carpenter
2012-12-02 20:24 ` Christian Lamparter
2012-12-02 22:17 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121202104238.GB16078@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=chunkeey@googlemail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).