From: Christian Lamparter <chunkeey@googlemail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] p54: potential signedness issue in p54_parse_rssical()
Date: Sun, 2 Dec 2012 14:54:56 +0100 [thread overview]
Message-ID: <201212021454.57147.chunkeey@googlemail.com> (raw)
In-Reply-To: <20121202103609.GA16078@elgon.mountain>
On Sunday 02 December 2012 11:36:09 Dan Carpenter wrote:
> "entries" is unsigned here, so it is never less than zero. In theory,
> len could be less than offset so I have added a check for that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Christian Lamparter <chunkeey@googlemail.com>
> diff --git a/drivers/net/wireless/p54/eeprom.c b/drivers/net/wireless/p54/eeprom.c
> index 1ef1bfe..d43e374 100644
> --- a/drivers/net/wireless/p54/eeprom.c
> +++ b/drivers/net/wireless/p54/eeprom.c
> @@ -541,8 +541,9 @@ static int p54_parse_rssical(struct ieee80211_hw *dev,
> entries = (len - offset) /
> sizeof(struct pda_rssi_cal_ext_entry);
>
> - if ((len - offset) % sizeof(struct pda_rssi_cal_ext_entry) ||
> - entries <= 0) {
> + if (len < offset ||
> + (len - offset) % sizeof(struct pda_rssi_cal_ext_entry) ||
> + entries == 0) {
> wiphy_err(dev->wiphy, "invalid rssi database.\n");
> goto err_data;
> }
>
prev parent reply other threads:[~2012-12-02 13:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 10:36 [patch] p54: potential signedness issue in p54_parse_rssical() Dan Carpenter
2012-12-02 13:54 ` Christian Lamparter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212021454.57147.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).