public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Seth Forshee <seth.forshee@canonical.com>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: fixing the warning storm for budding chipsets without ampdu_action defined
Date: Wed, 5 Dec 2012 08:04:31 -0600	[thread overview]
Message-ID: <20121205140431.GA31677@thinkpad-t410> (raw)
In-Reply-To: <CABPxzYKwA99yXhVR52L1UD=EGNNCotuR94d5pjfhOpnUj_G1DA@mail.gmail.com>

On Wed, Dec 05, 2012 at 04:37:19PM +0530, Krishna Chaitanya wrote:
> I have verified the patch with the checkpatch.pl, i think the
> whitespace got introduced when i copied the patch from the file to
> mail.
> The Mail editor (gmail/thunderbird) automatically converts all tabs to spaces.
> 
> What should be the ideal settings for VIM editor and lets say gmail/thunderbird.
> 
> for VIM i have done:
> 
> set tabstop=4
> set shiftwidth=4
> set expandtab

That's not correct for editing kernel source. You should have:

 set tapstop=8
 set shiftwidth=8
 set noexpandtab

Seth


      parent reply	other threads:[~2012-12-05 14:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-05  9:13 [PATCH] mac80211: fixing the warning storm for budding chipsets without ampdu_action defined Krishna Chaitanya
2012-12-05  9:17 ` Johannes Berg
2012-12-05 11:07   ` Krishna Chaitanya
2012-12-05 11:42     ` Johannes Berg
2012-12-05 14:04     ` Seth Forshee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121205140431.GA31677@thinkpad-t410 \
    --to=seth.forshee@canonical.com \
    --cc=chaitanya.mgit@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox