From: Christian Lamparter <chunkeey@googlemail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Gabor Juhos <juhosg@openwrt.org>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [PATCH 3/3] p54: zero-out rx_status
Date: Tue, 11 Dec 2012 16:38:15 +0100 [thread overview]
Message-ID: <201212111638.16033.chunkeey@googlemail.com> (raw)
In-Reply-To: <1355239813.9819.3.camel@jlt4.sipsolutions.net>
On Tuesday, December 11, 2012 04:30:13 PM Johannes Berg wrote:
> On Tue, 2012-12-11 at 16:25 +0100, Johannes Berg wrote:
>
> > > If this issue just popped up now, I suspect that
> > > something else is silently corrupting our SKBs
> > > [or can anybody see how rt2x00 hit this issue?]
>
> Oh, ok I assumed that rt2x00 RX SKBs are cleanly allocated, but now that
> I trace the code further I see that while the SKBs are on the queue
> inside rt2x00 they have something called "struct skb_frame_desc" on the
> skb->cb, so this is what's causing the rt2x00 issue. This should be
> mentioned in the rt2x00 commit, and all other drivers should be fine.
Ah, you are right. I assumed that rt2x00_queue stuff was only important
for TX. But it seems rt2x00 pci devices use them as well for RX.
Regards,
Chr
next prev parent reply other threads:[~2012-12-11 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 13:55 [PATCH 1/3] rt2x00: zero-out rx_status Gabor Juhos
2012-12-11 13:55 ` [PATCH 2/3] ath5k: " Gabor Juhos
2012-12-11 13:55 ` [PATCH 3/3] p54: " Gabor Juhos
2012-12-11 15:08 ` Christian Lamparter
2012-12-11 15:25 ` Johannes Berg
2012-12-11 15:30 ` Johannes Berg
2012-12-11 15:38 ` Christian Lamparter [this message]
2012-12-11 17:19 ` Gabor Juhos
2012-12-11 17:16 ` Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212111638.16033.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=juhosg@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).