From: Christian Lamparter <chunkeey@googlemail.com>
To: Solomon Peachy <pizza@shaftnet.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Steev Klimaszewski <steev@genesi-usa.com>,
Janusz Dziedzic <janusz.dziedzic@gmail.com>,
Dmitry Tarnyagin <abi.dmitryt@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2 00/21] cw1200: ST-Ericsson cw1200 wlan device driver
Date: Wed, 12 Dec 2012 16:13:12 +0100 [thread overview]
Message-ID: <201212121613.12750.chunkeey@googlemail.com> (raw)
In-Reply-To: <20121211232311.GA9080@shaftnet.org>
On Wednesday, December 12, 2012 12:23:11 AM Solomon Peachy wrote:
> On Fri, Jul 06, 2012 at 04:18:40PM -0400, John W. Linville wrote:
>
> IIRC it's because mac80211 doesn't provide a way of pre-allocating MIC
> space at the tail end of the frame -- the hardware performs the work but
> still needs the space in the payload. The code I'm maintaining has
> workarounds for this; not the most efficient solution but I'd rather see
> the code merged as-is, and then we can incrementally improve things
> (perhaps by enhancing mac80211 as needed)
Mac80211 already reserves at least 18 bytes tailroom [which can be
allocated by a simple skb_put]. In fact p54 uses this tailroom to
pass the MIC (8 bytes) + ICV (4 bytes) to the firmware. Do you need
more than 18 bytes?
Regards,
Chr
next prev parent reply other threads:[~2012-12-12 15:13 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <983b0e2d75af161b8e4dec02fc3497926a0080df-submit>
2012-03-02 20:26 ` [PATCHv2 00/21] cw1200: ST-Ericsson cw1200 wlan device driver Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 01/21] cw1200: cw1200.h, private driver data Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 02/21] cw1200: cw1200_plat.h, definition of the driver'ss platform data Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 03/21] cw1200: sbus.h, common device interface abstraction Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 04/21] cw1200: cw1200_sdio.c, implementation of SDIO wrapper for the driver Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 05/21] cw1200: hwio.*, device reg/mem map and low-level i/o primitives Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 06/21] cw1200: fwio.*, firmware downloading code for the cw1200 driver Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 07/21] cw1200: queue.*, implementation of TX queues of " Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 08/21] cw1200: wsm.*, implementation of device high-level interface Dmitry Tarnyagin
2012-04-26 13:29 ` Bob Copeland
2012-03-02 20:26 ` [PATCHv2 09/21] cw1200: txrx.*, implementation of datapath Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 10/21] cw1200: ht.h, small helper header with HT definitions Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 11/21] cw1200: bh.*, device serving thread Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 12/21] cw1200: sta.*, mac80211 STA callbacks Dmitry Tarnyagin
2012-04-29 3:49 ` Bob Copeland
2012-05-03 9:59 ` Dmitry Tarnyagin
2012-05-03 12:42 ` Bob Copeland
2012-03-02 20:26 ` [PATCHv2 13/21] cw1200: ap.*, mac80211 AP callbacks Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 14/21] cw1200: scan.*, mac80211 hw_scan callback Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 15/21] cw1200: debug.*, implementation of the driver's debugfs Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 16/21] cw1200: itp.*, internal device test and calibration code Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 17/21] cw1200: pm.*, power management code Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 18/21] cw1200: main.c, core initialization code Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 19/21] cw1200: TODO list Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 20/21] cw1200: Credits Dmitry Tarnyagin
2012-03-02 20:26 ` [PATCHv2 21/21] cw1200: Kconfig + Makefile for the driver Dmitry Tarnyagin
2012-05-09 6:58 ` [PATCHv2 00/21] cw1200: ST-Ericsson cw1200 wlan device driver Dmitry Tarnyagin
2012-05-31 5:45 ` Janusz Dziedzic
2012-07-05 18:16 ` Steev Klimaszewski
2012-07-06 20:18 ` John W. Linville
2012-12-11 23:23 ` Solomon Peachy
2012-12-12 14:40 ` Kalle Valo
2012-12-12 15:13 ` Christian Lamparter [this message]
2012-12-12 16:18 ` Solomon Peachy
2012-12-12 16:20 ` Johannes Berg
2012-12-13 14:53 ` Solomon Peachy
2012-12-12 18:19 ` John W. Linville
2012-05-02 15:22 Kevin Groeneveld
2012-05-02 16:01 ` Dmitry Tarnyagin
[not found] ` <CABF+-6XbdG_QMa0iQJMpbOsr4bXCq4mDEB6unkM8jxNGWYwFyQ@mail.gmail.com>
2012-05-02 16:51 ` Kevin Groeneveld
[not found] ` <4FA23DA0.3030207@stericsson.com>
2012-05-03 16:42 ` Kevin Groeneveld
2012-05-03 17:23 ` Dmitry Tarnyagin
2012-05-03 18:57 ` Kevin Groeneveld
2012-05-03 21:57 ` Janusz Dziedzic
2012-05-04 0:10 ` Kevin Groeneveld
2012-05-04 21:40 ` Kevin Groeneveld
2012-05-05 7:20 ` Janusz Dziedzic
2012-05-07 9:25 ` Janusz Dziedzic
2012-05-07 19:54 ` Kevin Groeneveld
2012-05-09 17:03 ` Kevin Groeneveld
2012-05-09 18:24 ` Dmitry Tarnyagin
2012-05-09 18:33 ` Johannes Berg
2012-05-09 18:56 ` Kevin Groeneveld
2012-05-09 19:37 ` Dmitry Tarnyagin
2012-05-09 20:37 ` Solomon Peachy
2012-05-09 20:59 ` Kevin Groeneveld
2012-05-10 13:07 ` Solomon Peachy
2012-05-10 20:03 ` Kevin Groeneveld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212121613.12750.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=abi.dmitryt@gmail.com \
--cc=janusz.dziedzic@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=pizza@shaftnet.org \
--cc=steev@genesi-usa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).