From: Bob Copeland <me@bobcopeland.com>
To: devel@lists.open80211s.org
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH/RFC] nl80211/cfg80211/mac80211: add NL80211_CMD_GET_MESH_SETUP
Date: Fri, 14 Dec 2012 14:00:27 -0500 [thread overview]
Message-ID: <20121214190027.GE3078@localhost> (raw)
In-Reply-To: <CAPjQAd8-pFCRQLb=t4Cx+RaLbU8ZMT5_1Xc36sNsRgjm4NdgJw@mail.gmail.com>
On Fri, Dec 14, 2012 at 10:17:24AM -0800, Javier Cardona wrote:
Thanks for the review!
> > + setup->is_authenticated = ifmsh->security & IEEE80211_MESH_SEC_AUTHED;
> + setup->is_authenticated = !!(ifmsh->security &
> IEEE80211_MESH_SEC_AUTHED));
>
> i.e. to force the value to be 0 or 1.
Agreed if they were ints, but in this case .is_authenticated and
.is_secure are type bool, so it shouldn't make a difference, right?
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2012-12-14 19:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 15:14 [PATCH/RFC] nl80211/cfg80211/mac80211: add NL80211_CMD_GET_MESH_SETUP Bob Copeland
2012-12-14 18:17 ` Javier Cardona
2012-12-14 18:59 ` Johannes Berg
2012-12-14 19:00 ` Bob Copeland [this message]
2012-12-14 19:08 ` Javier Cardona
2012-12-14 19:11 ` Bob Copeland
2012-12-28 14:43 ` Johannes Berg
2013-01-03 5:16 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121214190027.GE3078@localhost \
--to=me@bobcopeland.com \
--cc=devel@lists.open80211s.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).