From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Gabor Juhos <juhosg@openwrt.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Daniel Golle <dgolle@allnet.de>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [rt2x00-users] [PATCH 1/2] rt2x00: rt2800pci: verify ioremap return value
Date: Tue, 18 Dec 2012 22:57:08 +0100 [thread overview]
Message-ID: <20121218215708.GA4825@localhost.localdomain> (raw)
In-Reply-To: <1355847743-16659-1-git-send-email-juhosg@openwrt.org>
On Tue, Dec 18, 2012 at 05:22:22PM +0100, Gabor Juhos wrote:
> An ioremap call is allowed to fail, however
> the return value of that is not checked in
> the 'rt2800pci_read_eeprom_soc' function.
>
> The patch adds the missing check, and makes
> the function return an int value. The patch
> also converts the 'rt2800_read_eeprom' and
> 'rt2800_ops.read_eeprom' functions to return
> an int value, so the error value can be
> propagated up to the 'rt2800_validate_eeprom'
> function.
>
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Reviewed-by: Stanislaw Gruszka <stf_xl@wp.pl>
next prev parent reply other threads:[~2012-12-18 21:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 16:22 [PATCH 1/2] rt2x00: rt2800pci: verify ioremap return value Gabor Juhos
2012-12-18 16:22 ` [PATCH 2/2] rt2x00: rt2800pci: allow to load EEPROM data via firmware API Gabor Juhos
2012-12-18 22:22 ` [rt2x00-users] " Stanislaw Gruszka
2012-12-19 9:35 ` Gabor Juhos
2012-12-20 8:58 ` Kalle Valo
2012-12-20 11:06 ` Stanislaw Gruszka
2012-12-20 14:34 ` Gabor Juhos
2012-12-18 21:57 ` Stanislaw Gruszka [this message]
2012-12-19 9:34 ` [rt2x00-users] [PATCH 1/2] rt2x00: rt2800pci: verify ioremap return value Gabor Juhos
2012-12-18 23:58 ` Julian Calaby
2012-12-19 9:35 ` Gabor Juhos
2012-12-19 11:05 ` Jones Desougi
2012-12-19 11:59 ` Gabor Juhos
2013-01-07 20:02 ` John W. Linville
2013-01-07 20:37 ` Gabor Juhos
2013-01-07 21:08 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218215708.GA4825@localhost.localdomain \
--to=stf_xl@wp.pl \
--cc=dgolle@allnet.de \
--cc=juhosg@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).