From: Thomas Pedersen <thomas@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.org, linux-wireless@vger.kernel.org,
jlopex@gmail.com, j@wl.fi
Subject: Re: [PATCH v2 2/3] mac80211_hwsim: beacon at beacon interval
Date: Fri, 21 Dec 2012 10:30:53 -0800 [thread overview]
Message-ID: <20121221183053.GB24585@cable.cozybit.com> (raw)
In-Reply-To: <1356100584.9580.11.camel@jlt4.sipsolutions.net>
On Fri, Dec 21, 2012 at 03:36:24PM +0100, Johannes Berg wrote:
> On Thu, 2012-12-20 at 10:57 -0800, Thomas Pedersen wrote:
>
> > + else if (!hrtimer_is_queued(&data->beacon_timer)) {
> > + u64 tsf = le64_to_cpu(__mac80211_hwsim_get_tsf(data));
>
> This is odd, you haven't even modified __mac80211_hwsim_get_tsf() yet?
> Also, there's mac80211_hwsim_get_tsf() (although I'd argue that they
> should be the other way around wrt. endianness)
You're right, mac80211_hwsim_get_tsf() is less redundant. Also I guess
the timebase changes should go into the first patch.
Thomas
next prev parent reply other threads:[~2012-12-21 18:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 18:57 [PATCH v2 1/3] mac80211_hwsim: use hrtimer for beacon timers Thomas Pedersen
2012-12-20 18:57 ` [PATCH v2 2/3] mac80211_hwsim: beacon at beacon interval Thomas Pedersen
2012-12-21 14:36 ` Johannes Berg
2012-12-21 18:30 ` Thomas Pedersen [this message]
2012-12-20 18:57 ` [PATCH v2 3/3] mac80211_hwsim: emulate proper beaconing Thomas Pedersen
2012-12-21 14:37 ` Johannes Berg
2012-12-21 18:31 ` Thomas Pedersen
2012-12-21 14:33 ` [PATCH v2 1/3] mac80211_hwsim: use hrtimer for beacon timers Johannes Berg
2012-12-21 18:24 ` Thomas Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121221183053.GB24585@cable.cozybit.com \
--to=thomas@cozybit.com \
--cc=j@wl.fi \
--cc=jlopex@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).