Re: [PATCH for 3.8] mips: bcm47xx: select GPIOLIB for BCMA on bcm47xx platform

["John W. Linville" <linville@tuxdriver.com>]

Shouldn't this go to Ralf?

On Fri, Jan 04, 2013 at 10:03:11AM +0100, Arend van Spriel wrote:
> The Kconfig items BCM47XX_BCMA and BCM47XX_SSB selected
> respectively BCMA_DRIVER_GPIO and SSB_DRIVER_GPIO. These
> options depend on GPIOLIB without explicitly selecting it
> so it results in a warning when GPIOLIB is not set:
> 
> scripts/kconfig/conf --oldconfig Kconfig
> warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO ... unmet direct
> 	dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
> warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO ... unmet direct
> 	dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
> 
> which subsequently results in compile errors.
> 
> Cc: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> ---
>  arch/mips/bcm47xx/Kconfig |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig
> index d7af29f..ba61192 100644
> --- a/arch/mips/bcm47xx/Kconfig
> +++ b/arch/mips/bcm47xx/Kconfig
> @@ -8,8 +8,10 @@ config BCM47XX_SSB
>  	select SSB_DRIVER_EXTIF
>  	select SSB_EMBEDDED
>  	select SSB_B43_PCI_BRIDGE if PCI
> +	select SSB_DRIVER_PCICORE if PCI
>  	select SSB_PCICORE_HOSTMODE if PCI
>  	select SSB_DRIVER_GPIO
> +	select GPIOLIB
>  	default y
>  	help
>  	 Add support for old Broadcom BCM47xx boards with Sonics Silicon Backplane support.
> @@ -25,6 +27,7 @@ config BCM47XX_BCMA
>  	select BCMA_HOST_PCI if PCI
>  	select BCMA_DRIVER_PCI_HOSTMODE if PCI
>  	select BCMA_DRIVER_GPIO
> +	select GPIOLIB
>  	default y
>  	help
>  	 Add support for new Broadcom BCM47xx boards with Broadcom specific Advanced Microcontroller Bus.
> -- 
> 1.7.10.4
> 
> 
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.