Re: [PATCHv3 2/2] mac80211: in AD-HOC mode wait for the AUTH response

[Antonio Quartulli <ordex@autistici.org>]

[-- Attachment #1: Type: text/plain, Size: 2083 bytes --]

On Wed, Jan 02, 2013 at 10:40:55AM +0100, Nicolas Cavallari wrote:
> On 02/01/2013 07:32, Antonio Quartulli wrote:
> > Hi Johannes,
> > 
> > On Fri, Dec 28, 2012 at 03:51:08 +0100, Johannes Berg wrote:
> >> Anyway this part is really confusing. If userspace is handling auth
> >> frames, should the kernel really mark the station as authenticated? What
> >> then is the point in handling auth frames in userspace??
> 
> In IBSS mode, the "auth" state is essentially a no-op with the current code, just saying.
> 
> I do open system authentication in userspace, partly to fix these race conditions in a
> clean way, and to have more control over it in a more convenient way. That way, it is
> possible to hack things like retrying authentication at the user will if it failed the
> first time.
> I can also handle stations that do not answer auth frames much easier, such as skipping
> open system authentication if the other station engage actually tries to authenticate with us.
> 
> >> Any chance we could converge on a single implementation here?
> >>
> > 
> > Maybe yes :)
> > 
> > I think that leaving the station not AUTHenticated and let userspace do so would
> > be the best approach..but then we need a way to enable userspace to do it :)
> 
> What would happen to old userspace that expect that to be done in the kernel ?

if the userspace did not register for auth frames, then authentication will be
handled in the kernel (as I'm doing/changing now), while if the userspace
registered for such frames, then the kernel will assume that the authentication
will be handled by the userspace somehow and will not deal with it (but again,
in this way we need a command to let userspace set the AUTHenticated flag on a
station).

Cheers,


> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]