From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC 3/3] mac80211: Disable off-channel powersave when software scans are suspended
Date: Wed, 9 Jan 2013 12:03:44 +0100 [thread overview]
Message-ID: <20130109110343.GA13544@redhat.com> (raw)
In-Reply-To: <1357668645-5101-4-git-send-email-seth.forshee@canonical.com>
Hi
On Tue, Jan 08, 2013 at 12:10:45PM -0600, Seth Forshee wrote:
> Leaving powersave enabled while the scan is suspended requires the use
> of PS-Poll to retrieve frames buffered at the AP. PS-Poll isn't a very
> efficient means of data transfer and may not even work with drivers not
> supporting powersave. These problems can largely be avoided by simply
> disabling off-channel powersave when the scan is suspended and enabling
> it again when returning to off-channel operation.
>
> The results of this change are fantastic. Previously when using iperf I
> would see greatly decreased throughput (often dropping to 0 bits/sec for
> several seconds) and very high packet loss during software scans. This
> patch completely eliminates the packet loss and reduces the loss in
> throughput to very reasonable levels.
I posted a patch, which remove offchannel_ps_disable argument from
ieee80211_offchannel_return, since there were possible AP and STA power
save state mismash:
http://marc.info/?l=linux-wireless&m=135601089321822&w=2
It should give the same effect on performance as this patch.
Thanks
Stanislaw
next prev parent reply other threads:[~2013-01-09 11:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 18:10 [RFC] Fixes for problems with off-channel powersave Seth Forshee
2013-01-08 18:10 ` [RFC 1/3] mac80211: Add flushes to ensure off-channel PS is enabled during sw scans Seth Forshee
2013-01-16 23:34 ` Johannes Berg
2013-01-17 5:34 ` Seth Forshee
2013-01-08 18:10 ` [RFC 2/3] mac80211: Convey information about off-channel powersave to drivers Seth Forshee
2013-01-08 18:10 ` [RFC 3/3] mac80211: Disable off-channel powersave when software scans are suspended Seth Forshee
2013-01-09 11:03 ` Stanislaw Gruszka [this message]
2013-01-09 13:27 ` Seth Forshee
2013-01-09 13:40 ` [RFC] Fixes for problems with off-channel powersave Seth Forshee
2013-01-16 23:32 ` Johannes Berg
2013-01-17 5:34 ` Seth Forshee
2013-01-25 21:36 ` Johannes Berg
2013-01-25 22:11 ` Adrian Chadd
2013-01-16 23:31 ` Johannes Berg
2013-01-17 5:32 ` Seth Forshee
2013-01-17 0:29 ` Johannes Berg
2013-01-17 5:35 ` Seth Forshee
2013-01-25 21:34 ` Johannes Berg
2013-01-25 22:16 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109110343.GA13544@redhat.com \
--to=sgruszka@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).