From: Seth Forshee <seth.forshee@canonical.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
Ben Greear <greearb@candelatech.com>
Subject: Re: [PATCH 1/2] mac80211: synchronize scan off/on-channel and PS states
Date: Mon, 14 Jan 2013 10:49:06 -0600 [thread overview]
Message-ID: <20130114164906.GA3596@thinkpad-t410> (raw)
In-Reply-To: <1356010879-10054-1-git-send-email-sgruszka@redhat.com>
On Thu, Dec 20, 2012 at 02:41:18PM +0100, Stanislaw Gruszka wrote:
> Since:
>
> commit b23b025fe246f3acc2988eb6d400df34c27cb8ae
> Author: Ben Greear <greearb@candelatech.com>
> Date: Fri Feb 4 11:54:17 2011 -0800
>
> mac80211: Optimize scans on current operating channel.
>
> we do not disable PS while going back to operational channel (on
> ieee80211_scan_state_suspend) and deffer that until scan finish.
> But since we are allowed to send frames, we can send a frame to AP
> without PM bit set, so disable PS on AP side. Then when we switch
> to off-channel (in ieee80211_scan_state_resume) we do not enable PS.
> Hence we are off-channel with PS disabled, frames are not buffered
> by AP.
>
> To fix remove offchannel_ps_disable argument and always enable PS when
> going off-channel and disable it when going on-channel, like it was
> before.
>
> Cc: stable@vger.kernel.org # 2.6.39+
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
This patch makes a huge difference in performance and packet loss during
software scans in my testing with iperf.
Tested-by: Seth Forshee <seth.forshee@canonical.com>
next prev parent reply other threads:[~2013-01-14 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 13:41 [PATCH 1/2] mac80211: synchronize scan off/on-channel and PS states Stanislaw Gruszka
2012-12-20 13:41 ` [PATCH 2/2] mac80211: properly stop/wake queues before/after off-channel Stanislaw Gruszka
2012-12-20 13:46 ` Johannes Berg
2013-01-14 16:49 ` Seth Forshee [this message]
2013-01-16 14:06 ` [PATCH 1/2] mac80211: synchronize scan off/on-channel and PS states Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114164906.GA3596@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).