From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: Gertjan van Wingerde <gwingerde@gmail.com>,
Helmut Schaa <helmut.schaa@googlemail.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ivdoorn@gmail.com" <ivdoorn@gmail.com>,
"andihartmann@01019freenet.de" <andihartmann@01019freenet.de>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [PATCH] rt2x00: Improve TX status handling for BlockAckReq frames
Date: Sat, 26 Jan 2013 18:15:40 +0100 [thread overview]
Message-ID: <20130126171540.GC5834@localhost.localdomain> (raw)
In-Reply-To: <201301251853.24699.chunkeey@googlemail.com>
On Fri, Jan 25, 2013 at 06:53:23PM +0100, Christian Lamparter wrote:
> On Thursday 17 January 2013 19:42:52 Gertjan van Wingerde wrote:
> > On 17 jan. 2013, at 18:16, Christian Lamparter <chunkeey@googlemail.com> wrote:
> > > On Thursday, January 17, 2013 05:34:32 PM Helmut Schaa wrote:
> > >> Since rt2800 hardware isn't capable of reporting the TX status of
> > >> BlockAckReq frames implement the TX status handling of BARs in
> > >> rt2x00lib. We keep track of all BARs that are send out and try to
> > >> match incoming BAs to the appropriate BARs. This allows us to report a
> > >> more or less accurate TX status for BAR frames which in turn improves
> > >> BA session stability.
> > > ---
> > > What about:
> > >> commit 5b632fe85ec82e5c43740b52e74c66df50a37db3
> > >> Author: Stanislaw Gruszka <sgruszka@redhat.com>
> > >> Date: Mon Dec 3 12:56:33 2012 +0100
> > >> mac80211: introduce IEEE80211_HW_TEARDOWN_AGGR_ON_BAR_FAIL
> > >
> > > Should it be kept or dropped (as no driver uses it anymore?)
> >
> > I guess it should be dropped. I guess we could create a revert patch for that once
> > this patch has been merged.
> Looks like the rt2x00 patch has been accepted :)
> John, do you still want to remove the workaround, or
> can we keep it?
I'll post patch with revert.
Stanislaw
next prev parent reply other threads:[~2013-01-26 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 16:34 [PATCH] rt2x00: Improve TX status handling for BlockAckReq frames Helmut Schaa
2013-01-17 17:16 ` Christian Lamparter
2013-01-17 18:42 ` Gertjan van Wingerde
2013-01-18 8:51 ` Helmut Schaa
2013-01-25 17:53 ` Christian Lamparter
2013-01-26 17:15 ` Stanislaw Gruszka [this message]
2013-01-17 18:01 ` Andreas Hartmann
2013-01-17 18:41 ` Gertjan van Wingerde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130126171540.GC5834@localhost.localdomain \
--to=stf_xl@wp.pl \
--cc=andihartmann@01019freenet.de \
--cc=chunkeey@googlemail.com \
--cc=gwingerde@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).