linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Chaoming Li <chaoming_li@realsil.com.cn>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process()
Date: Sun, 27 Jan 2013 13:18:11 -0800	[thread overview]
Message-ID: <20130127211811.GA6680@roeck-us.net> (raw)

Hi all,

while browsing through 'warning: variable ‘...’ set but not used' warnings, I
found the following code in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process().

	while (!skb_queue_empty(&rx_queue)) {
        	_skb = skb_dequeue(&rx_queue);
		_rtl_usb_rx_process_agg(hw, skb);
		ieee80211_rx_irqsafe(hw, skb);
	}

Question: Should the parameter to _rtl_usb_rx_process_agg() and
ieee80211_rx_irqsafe() be '_skb' instead of 'skb' ?

Thanks,
Guenter

             reply	other threads:[~2013-01-27 21:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-27 21:18 Guenter Roeck [this message]
2013-01-27 22:11 ` Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process() Larry Finger
2013-01-27 23:52   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130127211811.GA6680@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Larry.Finger@lwfinger.net \
    --cc=chaoming_li@realsil.com.cn \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).