From: Yogesh Ashok Powar <yogeshp@marvell.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Lennert Buytenhek <buytenh@wantstofly.org>,
Nishant Sarmukadam <nishants@marvell.com>
Subject: Re: [PATCH] mwl8k: Announcing AP_VLAN suport
Date: Mon, 28 Jan 2013 12:35:02 +0530 [thread overview]
Message-ID: <20130128070502.GA442@markyou> (raw)
In-Reply-To: <1359114330.4655.0.camel@jlt4.sipsolutions.net>
> > if (priv->ap_macids_supported || priv->device_info->fw_image_ap) {
> > hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_AP);
> > + hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_AP_VLAN);
> > hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_STATION);
>
> Hmm, why is this needed? mac80211 should add it:
>
> /* if low-level driver supports AP, we also support VLAN */
> if (local->hw.wiphy->interface_modes & BIT(NL80211_IFTYPE_AP)) {
> hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_AP_VLAN);
> hw->wiphy->software_iftypes |= BIT(NL80211_IFTYPE_AP_VLAN);
> }
>
> Is this run too late, i.e. after registering hw? If so, that's a bug.
Hi Johannes,
We agree with you. There is no need to explicitly set
NL80211_IFTYPE_AP_VLAN support for AP driver. This patch
is redundant.
@John: Please ignore this patch.
Thanks
Yogesh
>
> johannes
>
prev parent reply other threads:[~2013-01-28 7:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 10:51 [PATCH] mwl8k: Announcing AP_VLAN suport Yogesh Ashok Powar
2013-01-25 11:45 ` Johannes Berg
2013-01-28 7:05 ` Yogesh Ashok Powar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130128070502.GA442@markyou \
--to=yogeshp@marvell.com \
--cc=buytenh@wantstofly.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).