From: "John W. Linville" <linville@tuxdriver.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwl4965: fix 'phys_addr' may be used uninitialized
Date: Fri, 15 Feb 2013 14:26:27 -0500 [thread overview]
Message-ID: <20130215192627.GE4981@tuxdriver.com> (raw)
In-Reply-To: <20130215095221.GE4392@redhat.com>
I still get the warning when building wireless-next on my F17 box
with this patch applied...
On Fri, Feb 15, 2013 at 10:52:21AM +0100, Stanislaw Gruszka wrote:
> This should fix:
>
> drivers/net/wireless/iwlegacy/4965-mac.c:1847:33: warning: 'phys_addr' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
> drivers/net/wireless/iwlegacy/4965-mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
> index 7941eb3..d2ab1cf 100644
> --- a/drivers/net/wireless/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/iwlegacy/4965-mac.c
> @@ -1843,7 +1843,7 @@ il4965_tx_skb(struct il_priv *il,
> il->ops->txq_attach_buf_to_tfd(il, txq, txcmd_phys, firstlen, 1, 0);
> dma_unmap_addr_set(out_meta, mapping, txcmd_phys);
> dma_unmap_len_set(out_meta, len, firstlen);
> - if (secondlen)
> + if (secondlen > 0)
> il->ops->txq_attach_buf_to_tfd(il, txq, phys_addr, secondlen,
> 0, 0);
>
> --
> 1.7.11.7
>
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2013-02-15 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 9:52 [PATCH] iwl4965: fix 'phys_addr' may be used uninitialized Stanislaw Gruszka
2013-02-15 19:26 ` John W. Linville [this message]
2013-02-18 8:40 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130215192627.GE4981@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=fengguang.wu@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).