Re: improve operational ANI in Mesh mode

[Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>]

[-- Attachment #1: Type: text/plain, Size: 2594 bytes --]

Hello Georgiewskiy,

On Sat, Feb 16, 2013 at 06:43:16AM +0400, Georgiewskiy Yuriy wrote:
> 
> Hi, in our setups we experience pure ANI operational in mesh mode
> VS AP mode, after debuffing and digging in ANI code i find what ANI
> in AP mode work in limited mode, i try this mode with mesh and seems
> getting same good operation as in AP mode, i am not familiar with ANI
> may be there is another better way to fix this issue?

We sometimes see some problems too where we suspect ANI, but we are not
and it's hard to reproduce. Our mesh networks are IBSS mode based, not
802.11s mesh, so I wonder if we can apply your findings to IBSS mode too.

Can you describe how your setup looks like, and what difference your patches
make? Did you experience some problem which was easily reproducable?
Also, do you plan to send a proper patch?

Thanks,
	Simon

> 
> changes what i made:
> 
> diff -ruN compat-drivers-3.7.6-1/drivers/net/wireless/ath/ath9k/ani.c compat-drivers-3.7.6-1-new/drivers/net/wireless/ath/ath9k/ani.c
> --- compat-drivers-3.7.6-1/drivers/net/wireless/ath/ath9k/ani.c	2013-02-11 04:23:53.000000000 +0400
> +++ compat-drivers-3.7.6-1-new/drivers/net/wireless/ath/ath9k/ani.c	2013-02-16 05:03:46.640746411 +0400
> @@ -303,7 +303,8 @@
>  	ah->stats.ast_ani_reset++;
> 
>  	/* only allow a subset of functions in AP mode */
> -	if (ah->opmode == NL80211_IFTYPE_AP) {
> +	if (ah->opmode == NL80211_IFTYPE_AP || ah->opmode == NL80211_IFTYPE_MESH_POINT) {
> +		ath_dbg(common, ANI, "only allow a subset of functions in AP or MESH mode");
>  		if (IS_CHAN_2GHZ(chan)) {
>  			ah->ani_function = (ATH9K_ANI_SPUR_IMMUNITY_LEVEL |
>  					    ATH9K_ANI_FIRSTEP_LEVEL);
> @@ -323,7 +324,8 @@
> 
>  	if (is_scanning ||
>  	    (ah->opmode != NL80211_IFTYPE_STATION &&
> -	     ah->opmode != NL80211_IFTYPE_ADHOC)) {
> +	     ah->opmode != NL80211_IFTYPE_ADHOC && +	     ah->opmode !=
> NL80211_IFTYPE_MESH_POINT)) {
>  		/*
>  		 * If we're scanning or in AP mode, the defaults (ini)
>  		 * should be in place. For an AP we assume the historical
> 
> 
> 
> C уважением                       With Best Regards
> Георгиевский Юрий.                Georgiewskiy Yuriy
> +7 4872 711666                    +7 4872 711666
> факс +7 4872 711143               fax +7 4872 711143
> Компания ООО "Ай Ти Сервис"       IT Service Ltd
> http://nkoort.ru                  http://nkoort.ru
> JID: GHhost@icf.org.ru            JID: GHhost@icf.org.ru
> YG129-RIPE                        YG129-RIPE


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]