Re: Fwd: [linux] [PATCH] ATH6KL: "Fix the byte alignment rule to avoid loss of bytes in a TCP segment" (#27)

Re: Fwd: [linux] [PATCH] ATH6KL: "Fix the byte alignment rule to avoid loss of bytes in a TCP segment" (#27)

[John W. Linville]

Thanks!  I'll ask Kalle to take a look, since ath6kl is his baby...

On Wed, Feb 27, 2013 at 09:19:09AM -0800, Linus Torvalds wrote:
> "How do I hate GitHub pull requests? Let me count the ways...."
> 
> That said, the bug description alone makes this worth forwarding,
> despite the cluelessness of GitHub pull requests. Myoungje Kim spent
> some time explaining the issue, so while I despise the github pull
> request format, I'm not faulting the effort spent on describing the
> patch.
> 
>                   Linus
> 
> ---------- Forwarded message ----------
> From: Steven Kim <notifications@github.com>
> Date: Tue, Feb 26, 2013 at 9:17 PM
> Subject: [linux] [PATCH] ATH6KL: "Fix the byte alignment rule to avoid
> loss of bytes in a TCP segment" (#27)
> To: torvalds/linux <linux@noreply.github.com>
> 
> 
> I found the driver bug which occur loss of some bytes on the TCP/IP stack.
> 
> Either first 3 bytes of the first received tcp segment or last one
> over MTU size file can be loss due to the byte alignment problem.
> Although ATH6KL_HTC_ALIGN_BYTES was defined
> for 'extra bytes for htc header alignment'
> in the patch "Fix buffer alignment for scatter-gather I/O"(1df94a8),
> there exists the bytes loss issue which means that it will be truncated
> 3 bytes in the transmitted file contents if a file which
> has over MTU size is transferred through TCP/IP stack.
> It doesn't look like TCP/IP stack bug of 3.5 or the latest version of
> kernel but the byte alignment issue.
> This patch is to use the roundup() function for the byte alignment
> rather than the predefined ATH6KL_HTC_ALIGN_BYTES.
> 
> Signed-off-by: Myoungje Kim mjei78@gmail.com
> 
> ________________________________
> 
> You can merge this Pull Request by running
> 
>   git pull https://github.com/kingpotato/linux master
> 
> Or view, comment on, or merge it at:
> 
>   https://github.com/torvalds/linux/pull/27
> 
> Commit Summary
> 
> ath6kl: Fix the byte alignment rule to avoid loss of bytes in a TCP segment
> 
> File Changes
> 
> M drivers/net/wireless/ath/ath6kl/init.c (4)
> M drivers/net/wireless/ath/ath6kl/main.c (4)
> 
> Patch Links:
> 
> https://github.com/torvalds/linux/pull/27.patch
> https://github.com/torvalds/linux/pull/27.diff
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: Fwd: [linux] [PATCH] ATH6KL: "Fix the byte alignment rule to avoid loss of bytes in a TCP segment" (#27)

[Kalle Valo]

Hi Myoungje,

(adding ath6kl-devel)

Myoungje Kim <mjei78@gmail.com> writes:

> How I appreciate your e-mail about my trivial patch.
> I am very happy due to receiving your reply(even though 'CC' ^^;)
>
> You don't need to count the ways you hate GitHub pull requests, 
> now I knew that enough ^^.
> It was the only easy way I've thought to commit to the main tree.
> You already know that I am very beginner.
>
>
> I'm ashamed to say that I spent about 3 weeks to find and debug this issue.
> My patch looks so simple,
> but I don't want anyone to trouble spending or wasting their time like me
> due to this issue makes me suspect all of linux kernel TCP/IP stack and curl,
> wget, ftp client, user HTTP client, library, everything of my system.
> So it made me to make pull request through github I`ve ever known as the way to
> commit.
>
> One more, now I knew that how to commit and how much I want to commit ^^.
> Thanks and have a good day~

No worries, it always takes some time to learn the process. And I hope
you send more ath6kl patches in the future :)

I'm on vacation right, but I will take a look at your patch next week.

BTW, I have documented the process of sending patches to ath6kl here:

http://wireless.kernel.org/en/users/Drivers/ath6kl#Hacking_on_ath6kl

Hopefully that helps. Please let me know if I need to improve it.

-- 
Kalle Valo