From: john <karl.beldan@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Karl Beldan <karl.beldan@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Karl Beldan <karl.beldan@rivierawaves.com>
Subject: Re: [PATCH v2 1/2] mac80211: get the rates masks from the txrc in rate_control_get_rate
Date: Mon, 4 Mar 2013 21:45:41 +0100 [thread overview]
Message-ID: <20130304204541.GA8819@gobelin> (raw)
In-Reply-To: <1362427924.21028.42.camel@jlt4.sipsolutions.net>
On Mon, Mar 04, 2013 at 09:12:04PM +0100, Johannes Berg wrote:
> On Mon, 2013-03-04 at 19:27 +0100, Karl Beldan wrote:
> > From: Karl Beldan <karl.beldan@rivierawaves.com>
> >
> > Currently it gets it from the sdata. This uses and updates the ad-hoc
> > masks of the ieee80211_tx_rate_control instead of copying them.
>
> Is there any need to update them?
>
> The change for "mask" seems to make it less efficient since it could
> otherwise be put into a register.
>
Totally, this commit spares the 10bytes copy of mcs_mask but adds a less
efficient indirection to mask.
I thought of it but kept the symmetry with mcs_mask.
Apparently you wouldn't mind the dissymmetry so I will re-send using mask
by value, plus I wrote "updates .." where it is more like "lets the
ad-hoc masks get overwritten".
Karl
next prev parent reply other threads:[~2013-03-04 20:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 18:27 [PATCH v2 1/2] mac80211: get the rates masks from the txrc in rate_control_get_rate Karl Beldan
2013-03-04 18:27 ` [PATCH v2 2/2] mac80211: fix the check for mcs rates masking Karl Beldan
2013-03-04 20:13 ` Johannes Berg
2013-03-04 20:51 ` john
2013-03-04 20:12 ` [PATCH v2 1/2] mac80211: get the rates masks from the txrc in rate_control_get_rate Johannes Berg
2013-03-04 20:45 ` john [this message]
2013-03-05 13:29 ` Felix Fietkau
2013-03-05 16:10 ` Karl Beldan
2013-03-05 18:53 ` Johannes Berg
2013-03-05 22:27 ` john
2013-03-10 22:35 ` Karl Beldan
2013-03-10 22:16 ` Karl Beldan
2013-03-10 22:27 ` Felix Fietkau
2013-03-10 23:06 ` Karl Beldan
2013-03-10 23:33 ` Felix Fietkau
2013-03-15 15:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304204541.GA8819@gobelin \
--to=karl.beldan@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=karl.beldan@rivierawaves.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).