Re: Question regarding minstrel(_ht) and retry limits

[Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>]

[-- Attachment #1: Type: text/plain, Size: 1434 bytes --]

On Thu, Mar 07, 2013 at 04:40:45PM +0100, Karl Beldan wrote:
> On Thu, Mar 07, 2013 at 04:31:00PM +0100, Simon Wunderlich wrote:
> > Hello list,
> > 
> > as you might be aware, it is possible to set short and long retry limits
> > to specify how often a frame should be retransmitted before getting dropped.
> > 
> > However, it appears that minstrel completely ignores any retry limit, and it is
> > also not applied later in the code path. I've hacked minstrel_ht a little bit
> > to apply the retry limits in minstrel_get_rate() before returning the rates
> > (i.e. just cutting retries at the end from the struct ieee80211_tx_rate array).
> > 
> > This worked for me, but is probably not clean either and might disturb minstrel
> > operation. Also minstrel uses much more retries than default retry limits
> > (short: 7, long: 4), so this patch might introduce behaviour changes.
> > 
> > What is your opinion on this? Can we get it properly supported? Does it hurt
> > to just use the first $retry_limit retries, and cut the rest at other rates
> > at the end?
> > 
> BTW, it also ignores max_rate_tries < 3 and rts thresholds.

Yup, regarding RTS we had a long discussion some time ago:

 * http://thread.gmane.org/gmane.linux.kernel.wireless.general/84459

regarding max_rate_tries, I guess this comes from the hardware? Does it hurt
to ignore it (as drivers will cut it anyway)?

Cheers,
	Simon

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]