From: "John W. Linville" <linville@tuxdriver.com>
To: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
Cc: Felix Fietkau <nbd@openwrt.org>,
linux-wireless@vger.kernel.org, mcgrof@qca.qualcomm.com
Subject: Re: [PATCH 3.8 1/3] ath9k_hw: fix calibration issues on chainmask that don't include chain 0
Date: Fri, 8 Mar 2013 15:34:51 -0500 [thread overview]
Message-ID: <20130308203451.GA402@tuxdriver.com> (raw)
In-Reply-To: <5138B656.5090408@neratec.com>
On Thu, Mar 07, 2013 at 04:46:30PM +0100, Wojciech Dubowik wrote:
> On 03/07/2013 03:59 PM, Felix Fietkau wrote:
> >On 2013-03-07 3:31 PM, Wojciech Dubowik wrote:
> >>There is a regression introduced by this patch when power save is off on
> >>the station for idle checks.
> >>I have AR9590 station with rx and tx chain set to 0x1 connected
> >>to legacy AP (based on Ar9390) with RF cable and 40dB attenuator.
> >>
> >>Before this patch in connection polling the station was properly sending
> >>null function to check whether AP is still there. After this patch it sends
> >>broadcast probe request which is anyway wrong or some 16 or so packets
> >>of random data (rarely). It manifests itself in lost connection because
> >>there
> >>is no ack from AP which is expected for null function.
> >>
> >>I have been following skb's up to the descriptor setting in ath9k and it was
> >>all ok i.e. proper null function with valid addresses.
> >>
> >>I have been bisecting it twice because it doesn't make much sense but maybe
> >>it's a HW issue?
> >You're right, it does not make much sense. I can't figure out how this
> >patch could possibly change the runtime behavior with tx chainmask set
> >to 0x1. Have you tried reverting this patch in a current build to see if
> >that fixes the issue?
> It does fix it. I will check tomorrow whether it's only AR9590 or also
> previous revisions. I will also try with different chainmasks. I will have
> to rescrew my setup...
Do I need to revert this one? Or is there a new fix coming?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2013-03-08 20:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 20:55 [PATCH 3.8 1/3] ath9k_hw: fix calibration issues on chainmask that don't include chain 0 Felix Fietkau
2013-01-20 20:55 ` [PATCH 3.8 2/3] ath9k_hw: fix chain swap setting when setting rx chainmask to 5 Felix Fietkau
2013-01-20 20:55 ` [PATCH 3.8 3/3] ath9k: allow setting arbitrary antenna masks on AR9003+ Felix Fietkau
2013-01-20 22:05 ` [PATCH 3.8 2/3] ath9k_hw: fix chain swap setting when setting rx chainmask to 5 Adrian Chadd
2013-01-20 22:31 ` Felix Fietkau
2013-03-07 14:31 ` [PATCH 3.8 1/3] ath9k_hw: fix calibration issues on chainmask that don't include chain 0 Wojciech Dubowik
2013-03-07 14:59 ` Felix Fietkau
2013-03-07 15:46 ` Wojciech Dubowik
2013-03-08 7:44 ` Wojciech Dubowik
2013-03-08 9:46 ` Wojciech Dubowik
2013-03-08 12:42 ` Felix Fietkau
2013-03-11 6:25 ` Wojciech Dubowik
2013-03-11 9:43 ` Wojciech Dubowik
2013-03-15 0:01 ` Felix Fietkau
2013-03-15 1:32 ` Felix Fietkau
2013-03-15 7:06 ` Wojciech Dubowik
2013-03-08 20:34 ` John W. Linville [this message]
2013-03-11 6:29 ` Wojciech Dubowik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308203451.GA402@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Wojciech.Dubowik@neratec.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@qca.qualcomm.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).