From: "John W. Linville" <linville@tuxdriver.com>
To: "Michał Pecio" <michal.pecio@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] orinoco_usb: don't release nonexistent firmware
Date: Fri, 8 Mar 2013 16:02:21 -0500 [thread overview]
Message-ID: <20130308210220.GD402@tuxdriver.com> (raw)
In-Reply-To: <20130307233341.6738c6e6@gmail.com>
This patch seems to have a lot of whitespace damage, etc. Please
revise it into something that applies with 'git am' and resubmit?
On Thu, Mar 07, 2013 at 11:33:41PM +0100, Michał Pecio wrote:
> From: Michal Pecio <michal.pecio@gmail.com>
>
> Initialize fw_entry to NULL to prevent cleanup code from passing
> bogus pointer to release_firmware() when priv allocation fails.
>
> Signed-off-by: Michal Pecio <michal.pecio@gmail.com>
> ---
>
> Applies against v3.8.2.
>
> Issue found by a static checker. I don't own this hardware so the
> patch hasn't been tested.
>
> Should be valid, though.
>
>
> drivers/net/wireless/orinoco/orinoco_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/orinoco/orinoco_usb.c
> b/drivers/net/wireless/orinoco/orinoco_usb.c index 01624dc..2e998ac
> 100644 --- a/drivers/net/wireless/orinoco/orinoco_usb.c
> +++ b/drivers/net/wireless/orinoco/orinoco_usb.c
> @@ -1578,7 +1578,7 @@ static int ezusb_probe(struct usb_interface
> *interface, struct ezusb_priv *upriv = NULL;
> struct usb_interface_descriptor *iface_desc;
> struct usb_endpoint_descriptor *ep;
> - const struct firmware *fw_entry;
> + const struct firmware *fw_entry = NULL;
> int retval = 0;
> int i;
>
> --
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2013-03-08 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 22:33 [PATCH] orinoco_usb: don't release nonexistent firmware Michał Pecio
2013-03-08 21:02 ` John W. Linville [this message]
2013-03-08 21:42 ` Michał Pecio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308210220.GD402@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.pecio@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).