From: Karl Beldan <karl.beldan@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Cc: Sam Leffler <sleffler@chromium.org>
Subject: Radiotap injected rates
Date: Sun, 17 Mar 2013 22:55:44 +0100 [thread overview]
Message-ID: <20130317215544.GA7031@gobelin> (raw)
Hi,
Some time ago the rate selection for radiotap injected frames did not
make it essentially for mac80211 getting short in IEEE80211_TX_CTL_*s.
Would it be acceptable to replace the originally proposed:
- if (!(tx->local->hw.flags & IEEE80211_HW_HAS_RATE_CONTROL))
+ if (!(tx->local->hw.flags & IEEE80211_HW_HAS_RATE_CONTROL) &&
+ !(info->flags & IEEE80211_TX_CTL_NO_RC))
CALL_TXH(ieee80211_tx_h_rate_ctrl);
with something like :
- if (!(tx->local->hw.flags & IEEE80211_HW_HAS_RATE_CONTROL))
+ if (!(tx->local->hw.flags & IEEE80211_HW_HAS_RATE_CONTROL) &&
+ !(info->flags & IEEE80211_TX_CTL_INJECTED && info->control.rates[i]))
CALL_TXH(ieee80211_tx_h_rate_ctrl);
?
Karl
next reply other threads:[~2013-03-17 21:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-17 21:55 Karl Beldan [this message]
2013-03-18 19:26 ` Radiotap injected rates Johannes Berg
2013-03-18 19:54 ` Karl Beldan
2013-03-22 12:24 ` Johannes Berg
2013-03-22 13:27 ` Karl Beldan
2013-03-22 13:32 ` Johannes Berg
2013-03-22 13:53 ` Karl Beldan
2013-03-22 14:00 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130317215544.GA7031@gobelin \
--to=karl.beldan@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sleffler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).