Re: [PATCH 1/2] mac80211: some fixes for ieee80211_do_stop while suspend

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Fri, Mar 15, 2013 at 04:44:30PM +0100, Johannes Berg wrote:
> On Mon, 2013-03-11 at 18:01 +0100, Stanislaw Gruszka wrote:
> > Is possible that we close interface while we are suspended, that
> > can result warning like below (and some others similar):
> 
> > Patch try to avoid calling most of drv callbacks when stopping interface
> > while suspended.
> 
> try :-)

It basically fix my test case, but I'm not sure if there are no other 
problems, not covered by this test.
 
> I really wonder if there's not a better solution ... I'll think about it
> a bit.

I thought about 2 solutions:

1) Do not drv_remove_interface() and drv_stop() on suspend. Need to
check and possibly rewrite drivers to work with that, so this is not
preferred solution for me.

2) Add "if (local->started && !local->suspended) check in some drv_
callbacks, IOW silently ignore callbacks when suspended. This looks
as even worse hack than this patch.

Stanislaw