From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Gabor Juhos <juhosg@openwrt.org>
Cc: linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [rt2x00-users] [PATCH 2/6] rt2x00: rt2400pci: use the rt2x00mmio_* routines
Date: Fri, 5 Apr 2013 23:05:09 +0200 [thread overview]
Message-ID: <20130405210509.GB2396@localhost.localdomain> (raw)
In-Reply-To: <20130405210222.GA2396@localhost.localdomain>
On Fri, Apr 05, 2013 at 11:02:22PM +0200, Stanislaw Gruszka wrote:
> On Fri, Apr 05, 2013 at 05:26:37PM +0200, Gabor Juhos wrote:
> > 2013.04.05. 15:32 keltezéssel, Stanislaw Gruszka írta:
> > > On Fri, Apr 05, 2013 at 08:27:01AM +0200, Gabor Juhos wrote:
> > >> Use the recently introduced rt2x00mmio_* routines
> > >> instead of the rt2x00pci_* variants.
> > >>
> > >> The patch contains no functional changes.
> > >>
> > >> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
> > >> ---
> > >> drivers/net/wireless/rt2x00/rt2400pci.c | 309 ++++++++++++++++---------------
> > >
> > > Why do you modify rt2400pci ?
> >
> > Because the rt2x00pci_* functions provided by the rt2x00mmio module has been
> > renamed in the first patch and those are using the rt2x00mmio_ prefix now. The
> > rt2x00mmio.h header provides definitions for the old function names but those
> > definitions are removed by the last patch.
>
> Ah, ok, but this breaks compilation. This should be avoided, to do not
> break bisection. Hance patches should be merged into one or incremental
> changes proposed that do not break compilation. Otherwise changes look
> ok for me.
Nevermind, you provided those compat defines, so compilation do not
break.
ACK for set.
Stanislaw
next prev parent reply other threads:[~2013-04-05 21:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 6:26 [PATCH 0/6] rt2x00: use rt2x00mmio prefix for rt2x00mmio module functions Gabor Juhos
2013-04-05 6:27 ` [PATCH 1/6] rt2x00: rt2x00mmio: use rt2x00mmio prefix in function names Gabor Juhos
2013-04-05 6:27 ` [PATCH 2/6] rt2x00: rt2400pci: use the rt2x00mmio_* routines Gabor Juhos
2013-04-05 13:32 ` Stanislaw Gruszka
2013-04-05 15:26 ` Gabor Juhos
2013-04-05 21:02 ` [rt2x00-users] " Stanislaw Gruszka
2013-04-05 21:05 ` Stanislaw Gruszka [this message]
2013-04-05 6:27 ` [PATCH 3/6] rt2x00: rt2500pci: " Gabor Juhos
2013-04-05 6:27 ` [PATCH 4/6] rt2x00: rt61pci: " Gabor Juhos
2013-04-05 6:27 ` [PATCH 5/6] rt2x00: rt2800pci: " Gabor Juhos
2013-04-05 6:27 ` [PATCH 6/6] rt2x00: rt2x00mmio: remove unused rt2x00pci_* defines Gabor Juhos
2013-04-05 8:16 ` [PATCH 0/6] rt2x00: use rt2x00mmio prefix for rt2x00mmio module functions Helmut Schaa
2013-04-05 9:50 ` Gabor Juhos
2013-04-05 21:14 ` Gertjan van Wingerde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405210509.GB2396@localhost.localdomain \
--to=stf_xl@wp.pl \
--cc=juhosg@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).