Re: [PATCH 1/3] cfg80211: add get_max_tp() API

[Antonio Quartulli <antonio@open-mesh.com>]

[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]

On Tue, Apr 09, 2013 at 03:25:08 -0700, Johannes Berg wrote:
> 
> > But the reported_rate field would just contain the index of the selected rate,
> > not the throughput. As far as I can tell the latter is an RC private information
> > (it not exported anywhere outside of the RC algorithm) and that is why I made
> > this API which would directly talk to minstrel and get this value.
> 
> Actually it would contain the entire rate configuration.
> 
> Anyway my concern is that you're adding something that's rather minstrel
> specific. It's not really usable by any other algorithm, you're
> reporting minstrel's estimation of the throughput. If you report the
> current "best" rate, that'll probably get you pretty much the same
> behaviour overall, but be more portable to other algorithms I think.

I understand your concern. My guess was that every algorithm was "somehow" able
to provide such measurement. The point is that the throughput value is computed
so that it also take probability of success into consideration.
This means that two nodes using the same rate may have different throughputs
(and this is important when building our distributed metric).

However, nothing prevents any algorithm to implement the API the way it can do.
I've not looked into other RC implementations yet, but I guess they would have a
similar value to return too?

Cheers,

> 
> johannes
> 

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]