From: Karl Beldan <karl.beldan@gmail.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net
Subject: Re: [PATCH v4 1/3] mac80211: improve the rate control API
Date: Sat, 20 Apr 2013 19:28:15 +0200 [thread overview]
Message-ID: <20130420172815.GB767@gobelin> (raw)
In-Reply-To: <20130420172247.GA767@gobelin>
On Sat, Apr 20, 2013 at 07:22:48PM +0200, Karl Beldan wrote:
> If we need to send 'low' rates (i.e those selected by *send_low) then 'low'
> rates get mixed with the rate table rates after fill_sta_table.
> If the driver doesn't advertise IEEE80211_HW_SUPPORTS_RC_TABLE, the
> solution could be to set info->control.rates[i > 0].idx to -1 in
> __rate_control_send_low, otherwise the driver would have to perform a
> check like rate_control_send_low already did.
>
Another idea would be to add a 'low' member in the rate table struct so
that we don't merge the rates when desired so ..
Karl
prev parent reply other threads:[~2013-04-20 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 15:28 [PATCH v4 1/3] mac80211: improve the rate control API Felix Fietkau
2013-04-19 15:28 ` [PATCH v4 2/3] mac80211/minstrel_ht: use the new " Felix Fietkau
2013-04-20 17:44 ` Karl Beldan
2013-04-21 7:57 ` Felix Fietkau
2013-04-21 8:45 ` Karl Beldan
2013-04-19 15:28 ` [PATCH v4 3/3] mac80211/minstrel: " Felix Fietkau
2013-04-20 17:22 ` [PATCH v4 1/3] mac80211: improve the " Karl Beldan
2013-04-20 17:28 ` Karl Beldan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130420172815.GB767@gobelin \
--to=karl.beldan@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).