From: Karl Beldan <karl.beldan@gmail.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net
Subject: Re: [PATCH v4 2/3] mac80211/minstrel_ht: use the new rate control API
Date: Sat, 20 Apr 2013 19:44:53 +0200 [thread overview]
Message-ID: <20130420174453.GC767@gobelin> (raw)
In-Reply-To: <1366385329-42690-2-git-send-email-nbd@openwrt.org>
On Fri, Apr 19, 2013 at 05:28:48PM +0200, Felix Fietkau wrote:
> @@ -846,6 +856,8 @@ minstrel_ht_update_caps(void *priv, struct ieee80211_supported_band *sband,
>
> msp->is_ht = true;
> memset(mi, 0, sizeof(*mi));
> +
> + mi->sta = sta;
> mi->stats_update = jiffies;
>
> ack_dur = ieee80211_frame_duration(sband->band, 10, 60, 1, 1);
> @@ -907,7 +919,6 @@ minstrel_ht_update_caps(void *priv, struct ieee80211_supported_band *sband,
> if (!n_supported)
> goto use_legacy;
>
> - /* init {mi,mi->groups[*]}->{max_tp_rate,max_tp_rate2,max_prob_rate} */
> minstrel_ht_update_stats(mp, mi);
>
This time you kept minstrel_ht_update_stats but you got rid of the call
to minstrel_ht_update_rates you previously had.
If you don't minstrel_ht_update_rates, ieee80211_tx_h_rate_ctrl will
TX_DROP the frame until minstrel's get_sample_rate returns != -1,
Maybe you could pair update_stats with ht_update_rates, e.g move/call
ht_update_stats in ht_update_rates ?
Karl
next prev parent reply other threads:[~2013-04-20 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 15:28 [PATCH v4 1/3] mac80211: improve the rate control API Felix Fietkau
2013-04-19 15:28 ` [PATCH v4 2/3] mac80211/minstrel_ht: use the new " Felix Fietkau
2013-04-20 17:44 ` Karl Beldan [this message]
2013-04-21 7:57 ` Felix Fietkau
2013-04-21 8:45 ` Karl Beldan
2013-04-19 15:28 ` [PATCH v4 3/3] mac80211/minstrel: " Felix Fietkau
2013-04-20 17:22 ` [PATCH v4 1/3] mac80211: improve the " Karl Beldan
2013-04-20 17:28 ` Karl Beldan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130420174453.GC767@gobelin \
--to=karl.beldan@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).