linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Jake Edge <jake@lwn.net>
Cc: linux-wireless@vger.kernel.org,
	Johannes Berg <johannes.berg@intel.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3
Date: Mon, 6 May 2013 17:30:45 +0200	[thread overview]
Message-ID: <20130506153044.GB1602@redhat.com> (raw)
In-Reply-To: <20130506083759.556dac76@chukar.edge2.net>

On Mon, May 06, 2013 at 08:37:59AM -0600, Jake Edge wrote:
> On Mon, 6 May 2013 14:38:06 +0200 Stanislaw Gruszka wrote:
> 
> > > I bisected the problem to:
> > > 
> > > commit 1672c0e31917f49d31d30d79067103432bc20cc7
> 
> > > What more information is needed from me?  I may still mess around
> > > with trying to revert that patch just to nail it down for sure, but
> > > two separate bisection exercises ended up at the same place.
> > 
> > Below patch should restore old mac80211 behaviour, by stop
> > telling mac that 4965 supports TX ACK status. Does it help?
> 
> Yup, that fixed the problem, thanks.  So did reverting Johannes's
> commit above, fwiw, but just turning off that flag in 3.9 as your patch
> does fixes it.
> 
> seems like that needs to head to Linus and the stable folks ...

We can fix the problem that way, but I'm not sure if that is the best
way. IEEE80211_HW_REPORTS_TX_ACK_STATUS is nice to have as long hardware
really supports that feature.

I thought this happen because 4965 firmware does not mark tx status
ack for PROBE_REQUEST frame, because it is not acked by standard 
ACK frame, but by PROBE_RESPONSE frame. But if so, I would also see
the breakage on my setup, but I don't - it works quite well here. So
perhaps something different is broken on commit
1672c0e31917f49d31d30d79067103432bc20cc7 , that make we can not
associate with some APs.

Let me think a bit longer about this issue. Also maybe Johannes will
have some thoughts.

Stanislaw 

  reply	other threads:[~2013-05-06 15:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-05 20:38 Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3 Jake Edge
2013-05-06 12:38 ` Stanislaw Gruszka
2013-05-06 14:37   ` Jake Edge
2013-05-06 15:30     ` Stanislaw Gruszka [this message]
2013-05-06 15:31       ` Johannes Berg
2013-05-06 15:44         ` Johannes Berg
2013-05-07  8:42           ` Stanislaw Gruszka
2013-05-07  8:46             ` Emmanuel Grumbach
2013-05-07 13:53             ` Johannes Berg
2013-05-07 15:35               ` Stanislaw Gruszka
2013-05-07 16:07                 ` [PATCH 3.10] iwl4965: workaround connection regression on passive channel Stanislaw Gruszka
2013-05-22 11:59                 ` Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3 Stanislaw Gruszka
2013-05-24 20:28                   ` Johannes Berg
2013-05-06 15:11 ` Johannes Berg
2013-05-06 15:21   ` Jake Edge
2013-05-06 15:24     ` Johannes Berg
2013-05-06 15:29       ` Jake Edge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130506153044.GB1602@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=jake@lwn.net \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).