From: Stanislaw Gruszka <sgruszka@redhat.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Jake Edge <jake@lwn.net>,
linux-wireless@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: [PATCH 3.10] iwl4965: workaround connection regression on passive channel
Date: Tue, 7 May 2013 18:07:06 +0200 [thread overview]
Message-ID: <20130507160705.GC1576@redhat.com> (raw)
In-Reply-To: <20130507153525.GB1576@redhat.com>
Jake reported that since commit 1672c0e31917f49d31d30d79067103432bc20cc7
"mac80211: start auth/assoc timeout on frame status", he is unable to
connect to his AP, which is configured to use passive channel.
After switch to passive channel 4965 firmware drops any TX packet until
it receives beacon. Before commit 1672c0e3 we waited on channel and
retransmit packet after 200ms, that makes we receive beacon on the
meantime and association process succeed. New mac80211 behaviour cause
that any ASSOC frame fail immediately on iwl4965 and we can not
associate.
This patch restore old mac80211 behaviour for iwl4965, by removing
IEEE80211_HW_REPORTS_TX_ACK_STATUS feature. This feature will be
added again to iwl4965 driver, when different, more complex
workaround for this firmware issue, will be added to the driver.
Cc: stable@vger.kernel.org # 3.9
Bisected-by: Jake Edge <jake@lwn.net>
Reported-and-tested-by: Jake Edge <jake@lwn.net>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/wireless/iwlegacy/4965-mac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
index b8f82e6..9a95045 100644
--- a/drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
@@ -5741,8 +5741,7 @@ il4965_mac_setup_register(struct il_priv *il, u32 max_probe_length)
hw->flags =
IEEE80211_HW_SIGNAL_DBM | IEEE80211_HW_AMPDU_AGGREGATION |
IEEE80211_HW_NEED_DTIM_BEFORE_ASSOC | IEEE80211_HW_SPECTRUM_MGMT |
- IEEE80211_HW_REPORTS_TX_ACK_STATUS | IEEE80211_HW_SUPPORTS_PS |
- IEEE80211_HW_SUPPORTS_DYNAMIC_PS;
+ IEEE80211_HW_SUPPORTS_PS | IEEE80211_HW_SUPPORTS_DYNAMIC_PS;
if (il->cfg->sku & IL_SKU_N)
hw->flags |=
IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS |
--
1.7.11.7
next prev parent reply other threads:[~2013-05-07 16:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-05 20:38 Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3 Jake Edge
2013-05-06 12:38 ` Stanislaw Gruszka
2013-05-06 14:37 ` Jake Edge
2013-05-06 15:30 ` Stanislaw Gruszka
2013-05-06 15:31 ` Johannes Berg
2013-05-06 15:44 ` Johannes Berg
2013-05-07 8:42 ` Stanislaw Gruszka
2013-05-07 8:46 ` Emmanuel Grumbach
2013-05-07 13:53 ` Johannes Berg
2013-05-07 15:35 ` Stanislaw Gruszka
2013-05-07 16:07 ` Stanislaw Gruszka [this message]
2013-05-22 11:59 ` Stanislaw Gruszka
2013-05-24 20:28 ` Johannes Berg
2013-05-06 15:11 ` Johannes Berg
2013-05-06 15:21 ` Jake Edge
2013-05-06 15:24 ` Johannes Berg
2013-05-06 15:29 ` Jake Edge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507160705.GC1576@redhat.com \
--to=sgruszka@redhat.com \
--cc=jake@lwn.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).