linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jouni Malinen <j@w1.fi>
To: Arend van Spriel <arend@broadcom.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	"hostap@lists.shmoo.com" <hostap@lists.shmoo.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Jithu Jance <jithu@broadcom.com>
Subject: Re: P2P Device support: how to deal with p2p_no_group_iface option
Date: Mon, 27 May 2013 21:11:12 +0300	[thread overview]
Message-ID: <20130527181112.GA20210@w1.fi> (raw)
In-Reply-To: <51A36603.7020403@broadcom.com>

On Mon, May 27, 2013 at 03:56:19PM +0200, Arend van Spriel wrote:
> In this mac80211_hwsim is a special case. We could make P2P_DEVICE
> support in mac80211_hwsim optional using module parameter to allow
> testing both cases.

Yes, that would be helpful. I don't understand why my test setup moves
to using P2P Device by default when mac80211_hwsim is perfectly capable
of operating without that.. I have been thinking of applying the
wpa_supplicant changes in a way that would make them disabled by default
and use a runtime configuration parameter (e.g., driver_param to
driver_nl80211.c) to enable this functionality for now. This would allow
the patches to go in now and make it somewhat easier to test them.
Anyway, if mac80211_hwsim changes its default behavior, this would be of
lesser needed (well, once a new kernel release or compat-drivers gets
released).

In general, I don't think it is a good idea to change existing behavior
with a kernel or wpa_supplicant upgrade. It is obviously fine if this is
needed for the functionality to work in the first place, but that is not
the case with mac80211_hwsim.

-- 
Jouni Malinen                                            PGP id EFC895FA

  parent reply	other threads:[~2013-05-27 18:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-25 11:23 P2P Device support: how to deal with p2p_no_group_iface option Arend van Spriel
2013-05-27  9:03 ` Johannes Berg
2013-05-27 13:56   ` Arend van Spriel
2013-05-27 13:59     ` Johannes Berg
2013-05-27 14:03       ` Arend van Spriel
2013-05-27 15:53         ` Johannes Berg
2013-05-27 17:40           ` Arend van Spriel
2013-05-27 18:11     ` Jouni Malinen [this message]
2013-05-27 19:15       ` Johannes Berg
2013-05-27 19:20         ` Arend van Spriel
2013-05-27 19:27           ` Johannes Berg
2013-05-27 18:51     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130527181112.GA20210@w1.fi \
    --to=j@w1.fi \
    --cc=arend@broadcom.com \
    --cc=hostap@lists.shmoo.com \
    --cc=jithu@broadcom.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).