Re: [PATCHv3 00/18] Add support for 5 and 10 MHz channels

[Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>]

[-- Attachment #1: Type: text/plain, Size: 5089 bytes --]

Hey,

just to bump here - this patchset is idling around for quite some time now.
I can integrate Felix suggestions easily if not a maintainer would like to do
that. Any further comments/suggestions?

Thanks,
	Simon

On Thu, May 16, 2013 at 01:00:27PM +0200, Simon Wunderlich wrote:
> This patchset adds support for 5 and 10 MHz in nl80211/cfg80211/mac80211
> and enables support in ath5k and ath9k, which already support this feature
> on the driver side. 5 and 10 MHz wide channels might be useful for:
> 
>  * long shot links, as the transmissions are more robust
>  * future support for 802.11y which allows some 5 and 10 MHz channels in
>    3.6 GHz range
>  * future support for 802.11p which uses 10 MHz in 5.9 GHz range
>  * ... and more "special" applications.
> 
> This patchset enables 5 and 10 MHz channels only for OFDM, and without
> HT/MIMO/aggregation (for now). Support may be added later.
> 
> Changes to PATCHv2:
>  * instead of introducing new bitrate tables, use bitrate flags which mark
>    the bitrate with support for 5/10 MHz. All bitrates have then to be
>    calculated manually.
> --> this saves a few changes where we only operate on indexes anyway,
>     but requires some more checking at other parts where it is required
>     to see if the rate is supported in 5/10 MHz. At least it is not
>     that ugly and bloaty, and also saves a lot of code in drivers.
> * various DIV_ROUND_UP()s have been used instead of manual conversions
> --> this was squashed with the "big" bitrate adjustment patch (-1 patch)
> * found a bug in the rate mask matching code, which is fixed (+1 patch)
> * fixed a few bugs I introuced myself. :)
> 
> As always, any comments are appreciated!
> Cheers,
>         Simon
> 
> Simon Wunderlich (18):
>   nl80211/cfg80211: add 5 and 10 MHz defines and wiphy flag
>   nl80211: add rate flags for 5/10 Mhz channels
>   mac80211: Fix rate control mask matching call
>   mac80211: fix various components for the new 5 and 10 MHz widths
>   mac80211: fix timing for 5 MHz and 10 MHz channels
>   mac80211: select and adjust bitrates according for channel mode
>   mac80211: add radiotap flag and handling for 5/10 MHz
>   cfg80211/mac80211: use reduced txpower for 5 and 10 MHz
>   mac80211: change IBSS channel state to chandef
>   nl80211: allow 5 and 10 MHz channels for IBSS
>   ath9k: always use SIFS times from OFDM for 5/10 MHz
>   ath9k: use chandef instead of channel_type
>   ath9k: report 5/10 MHz channels
>   ath9k: set 5/10 MHz supported channels and fix bitrate
>   ath9k: announce that ath9k supports 5/10 MHz
>   ath5k: report 5/10 MHz channels
>   ath5k: set 5/10 MHz supported channels and fix duration
>   ath5k: enable support for 5 MHz and 10 MHz channels
> 
>  drivers/net/wireless/ath/ath5k/ath5k.h        |    1 +
>  drivers/net/wireless/ath/ath5k/base.c         |   59 ++++++++--
>  drivers/net/wireless/ath/ath5k/base.h         |    2 +-
>  drivers/net/wireless/ath/ath5k/mac80211-ops.c |    2 +-
>  drivers/net/wireless/ath/ath5k/pcu.c          |    2 +
>  drivers/net/wireless/ath/ath5k/qcu.c          |   25 +++-
>  drivers/net/wireless/ath/ath9k/common.c       |   67 +++++++----
>  drivers/net/wireless/ath/ath9k/common.h       |    3 +-
>  drivers/net/wireless/ath/ath9k/htc_drv_main.c |    5 +-
>  drivers/net/wireless/ath/ath9k/hw.c           |    5 +-
>  drivers/net/wireless/ath/ath9k/init.c         |   29 +++--
>  drivers/net/wireless/ath/ath9k/main.c         |    8 +-
>  drivers/net/wireless/ath/ath9k/rc.c           |   10 +-
>  drivers/net/wireless/ath/ath9k/recv.c         |   11 ++
>  include/net/cfg80211.h                        |   55 +++++++++
>  include/net/ieee80211_radiotap.h              |    4 +
>  include/net/mac80211.h                        |    5 +-
>  include/uapi/linux/nl80211.h                  |    4 +
>  net/mac80211/cfg.c                            |   36 +++++-
>  net/mac80211/ibss.c                           |  101 +++++++++++-----
>  net/mac80211/ieee80211_i.h                    |   45 ++++++-
>  net/mac80211/iface.c                          |    2 +-
>  net/mac80211/main.c                           |    2 +-
>  net/mac80211/mesh.c                           |    4 +-
>  net/mac80211/mesh_plink.c                     |    8 +-
>  net/mac80211/mlme.c                           |   99 ++++++++++++----
>  net/mac80211/rate.c                           |   60 +++++-----
>  net/mac80211/rc80211_minstrel.c               |   29 ++++-
>  net/mac80211/rc80211_minstrel_ht.c            |   11 +-
>  net/mac80211/rx.c                             |   28 +++--
>  net/mac80211/status.c                         |   17 ++-
>  net/mac80211/tx.c                             |   16 ++-
>  net/mac80211/util.c                           |  157 +++++++++++++++++++------
>  net/wireless/chan.c                           |   57 +++++++--
>  net/wireless/nl80211.c                        |   23 +++-
>  35 files changed, 761 insertions(+), 231 deletions(-)
> 
> -- 
> 1.7.10.4
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]