[PATCH -next] cw1200: convert to use simple_open()

[PATCH -next] cw1200: convert to use simple_open()

[Wei Yongjun]

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

This removes an open coded simple_open() function and
replaces file operations references to the function
with simple_open() instead.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/net/wireless/cw1200/debug.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/net/wireless/cw1200/debug.c b/drivers/net/wireless/cw1200/debug.c
index b815181..eb40c9c 100644
--- a/drivers/net/wireless/cw1200/debug.c
+++ b/drivers/net/wireless/cw1200/debug.c
@@ -357,12 +357,6 @@ static const struct file_operations fops_counters = {
 	.owner = THIS_MODULE,
 };
 
-static int cw1200_generic_open(struct inode *inode, struct file *file)
-{
-	file->private_data = inode->i_private;
-	return 0;
-}
-
 #ifdef CONFIG_CW1200_ETF
 static int cw1200_etf_out_show(struct seq_file *seq, void *v)
 {
@@ -511,7 +505,7 @@ static ssize_t cw1200_wsm_dumps(struct file *file,
 }
 
 static const struct file_operations fops_wsm_dumps = {
-	.open = cw1200_generic_open,
+	.open = simple_open,
 	.write = cw1200_wsm_dumps,
 	.llseek = default_llseek,
 };

Re: [PATCH -next] cw1200: convert to use simple_open()

[Solomon Peachy]

[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]

On Thu, May 30, 2013 at 07:42:35PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> This removes an open coded simple_open() function and
> replaces file operations references to the function
> with simple_open() instead.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Acked-by: Solomon Peachy <pizza@shaftnet.org>

> ---
>  drivers/net/wireless/cw1200/debug.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/net/wireless/cw1200/debug.c b/drivers/net/wireless/cw1200/debug.c
> index b815181..eb40c9c 100644
> --- a/drivers/net/wireless/cw1200/debug.c
> +++ b/drivers/net/wireless/cw1200/debug.c
> @@ -357,12 +357,6 @@ static const struct file_operations fops_counters = {
>  	.owner = THIS_MODULE,
>  };
>  
> -static int cw1200_generic_open(struct inode *inode, struct file *file)
> -{
> -	file->private_data = inode->i_private;
> -	return 0;
> -}
> -
>  #ifdef CONFIG_CW1200_ETF
>  static int cw1200_etf_out_show(struct seq_file *seq, void *v)
>  {
> @@ -511,7 +505,7 @@ static ssize_t cw1200_wsm_dumps(struct file *file,
>  }
>  
>  static const struct file_operations fops_wsm_dumps = {
> -	.open = cw1200_generic_open,
> +	.open = simple_open,
>  	.write = cw1200_wsm_dumps,
>  	.llseek = default_llseek,
>  };
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Solomon Peachy        		       pizza at shaftnet dot org	 
Delray Beach, FL                          ^^ (mail/jabber) ^^
Quidquid latine dictum sit, altum viditur.

[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]