From: Solomon Peachy <pizza@shaftnet.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: linville@tuxdriver.com, yongjun_wei@trendmicro.com.cn,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH -next] cw1200: use module_spi_driver to simplify the code
Date: Sat, 1 Jun 2013 08:02:35 -0400 [thread overview]
Message-ID: <20130601120235.GD20362@shaftnet.org> (raw)
In-Reply-To: <CAPgLHd9e+T7UVET28Xe3RP05s2jVJdLx4TRtw3V635+HnKjnZA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]
On Thu, May 30, 2013 at 07:42:54PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> module_spi_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Solomon Peachy <pizza@shaftnet.org>
> ---
> drivers/net/wireless/cw1200/cw1200_spi.c | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/drivers/net/wireless/cw1200/cw1200_spi.c b/drivers/net/wireless/cw1200/cw1200_spi.c
> index 04af685..1e6c58d 100644
> --- a/drivers/net/wireless/cw1200/cw1200_spi.c
> +++ b/drivers/net/wireless/cw1200/cw1200_spi.c
> @@ -464,17 +464,4 @@ static struct spi_driver spi_driver = {
> },
> };
>
> -/* Init Module function -> Called by insmod */
> -static int __init cw1200_spi_init(void)
> -{
> - return spi_register_driver(&spi_driver);
> -}
> -
> -/* Called at Driver Unloading */
> -static void __exit cw1200_spi_exit(void)
> -{
> - spi_unregister_driver(&spi_driver);
> -}
> -
> -module_init(cw1200_spi_init);
> -module_exit(cw1200_spi_exit);
> +module_spi_driver(spi_driver);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Solomon Peachy pizza at shaftnet dot org
Delray Beach, FL ^^ (mail/jabber) ^^
Quidquid latine dictum sit, altum viditur.
[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]
prev parent reply other threads:[~2013-06-01 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 11:42 [PATCH -next] cw1200: use module_spi_driver to simplify the code Wei Yongjun
2013-06-01 12:02 ` Solomon Peachy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130601120235.GD20362@shaftnet.org \
--to=pizza@shaftnet.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).