From: Solomon Peachy <pizza@shaftnet.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>,
Ajitpal Singh <ajitpal.singh@stericsson.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cw1200: fix some obvious mistakes
Date: Sun, 2 Jun 2013 09:27:21 -0400 [thread overview]
Message-ID: <20130602132721.GB3875@shaftnet.org> (raw)
In-Reply-To: <20130602122954.GA3875@shaftnet.org>
[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]
On Sun, Jun 02, 2013 at 08:29:54AM -0400, Solomon Peachy wrote:
> > * Add comments about passing GPIO numbers in platform_data:
> > You should not use IORESOURCE_IO, which is for legacy ISA
> > I/O ports on PCs, not for GPIOs.
>
> Fair enough. The use of resources was something already in the driver
> when I inherited it, but I've seen this pattern a lot elsewhere. Is
> there a specific driver I should reference instead?
Reading linux/ioport.h I don't see a type that seems to be a better fit.
It's not MEM, REG, IRQ, DMA, or BUS. IO seems to be the only type that
fits.
The reason the driver uses struct resources instead of straight-up
numeric GPIO fields is for the 'name' field in the resources.
Given that the use of platform_data pretty much makes it impossible to
have more than one of these devices in a system at a time, there doesn't
seem to be a point to using named resources.
So I'll change these resource lists to using straight-up ints.
- Solomon
--
Solomon Peachy pizza at shaftnet dot org
Delray Beach, FL ^^ (email/xmpp) ^^
Quidquid latine dictum sit, altum viditur.
[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2013-06-02 13:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 22:37 [PATCH] cw1200: fix some obvious mistakes Arnd Bergmann
2013-06-02 12:29 ` Solomon Peachy
2013-06-02 13:27 ` Solomon Peachy [this message]
2013-06-02 13:59 ` Arnd Bergmann
2013-06-02 14:47 ` Solomon Peachy
2013-06-02 19:38 ` Linus Walleij
2013-06-03 8:40 ` Arnd Bergmann
2013-06-05 4:08 ` Solomon Peachy
2013-06-05 12:08 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130602132721.GB3875@shaftnet.org \
--to=pizza@shaftnet.org \
--cc=ajitpal.singh@stericsson.com \
--cc=arnd@arndb.de \
--cc=dmitry.tarnyagin@lockless.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).