From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3.wp.pl ([212.77.101.7]:57565 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755117Ab3FBXcu (ORCPT ); Sun, 2 Jun 2013 19:32:50 -0400 Date: Mon, 3 Jun 2013 01:32:47 +0200 From: Jakub Kicinski To: Johannes Berg Cc: linux-wireless@vger.kernel.org Subject: wireless-testing: lockdep warning in __ieee80211_request_smps Message-ID: <20130603013247.33849c6c@north> (sfid-20130603_013254_066582_3E81ADE4) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, bringing interface up for the first time (or changing PS settings) cause following warning in current wireless-testing: WARNING: at /home/kuba/wireless-testing/net/mac80211/cfg.c:2321 __ieee80211_request_smps+0xc5/0xf0 [mac80211]() Modules linked in: rt2800usb rt2x00usb ... CPU: 1 PID: 1945 Comm: ifconfig Not tainted 3.10.0-rc3-wl+ #1 Hardware name: Gigabyte Technology Co., Ltd. GA-MA790XT-UD4P/GA-MA790XT-UD4P, BIOS F9b 08/17/2012 0000000000000009 ffff88021872bb48 ffffffff815d82ad ffff88021872bb88 ffffffff8103db10 ffff88021872bb78 ffff88021f8eaac0 0000000000000001 ffff8802188d09e0 ffff88021f8eab58 0000000000000001 ffff88021872bb98 Call Trace: [] dump_stack+0x19/0x1b [] warn_slowpath_common+0x70/0xa0 [] warn_slowpath_null+0x1a/0x20 [] __ieee80211_request_smps+0xc5/0xf0 [mac80211] [] ieee80211_set_power_mgmt+0x81/0x100 [mac80211] [] cfg80211_netdev_notifier_call+0x3e5/0x620 [cfg80211] [] ? dp_device_event+0x48/0x110 [] notifier_call_chain+0x4d/0x70 [] __raw_notifier_call_chain+0xe/0x10 [] raw_notifier_call_chain+0x16/0x20 [] call_netdevice_notifiers+0x36/0x60 [] __dev_notify_flags+0x38/0x90 [] dev_change_flags+0x45/0x70 [] devinet_ioctl+0x639/0x720 [] ? dev_ioctl+0x260/0x750 [] inet_ioctl+0x75/0x90 [] sock_do_ioctl+0x30/0x70 [] ? avc_has_perm_flags+0x28/0x1e0 [] sock_ioctl+0x84/0x2b0 [] do_vfs_ioctl+0x97/0x640 [] ? inode_has_perm.isra.24.constprop.66+0x2a/0x30 [] ? file_has_perm+0x97/0xb0 [] SyS_ioctl+0x91/0xb0 [] ? lockdep_sys_exit_thunk+0x35/0x67 [] system_call_fastpath+0x16/0x1b It seems that wdev.mtx lock is neither held in nl80211_set_power_save nor in cfg80211_netdev_notifier_call. I couldn't find any patch addressing this, is it a known issue? -- kuba