From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Gabor Juhos <juhosg@openwrt.org>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [PATCH 1/2] rt2x00: convert rt2x00_ops.extra_tx_headroom to be a fuction
Date: Wed, 5 Jun 2013 14:51:30 +0200 [thread overview]
Message-ID: <20130605125130.GA3367@redhat.com> (raw)
In-Reply-To: <1370429640-31565-1-git-send-email-juhosg@openwrt.org>
On Wed, Jun 05, 2013 at 12:53:59PM +0200, Gabor Juhos wrote:
> The rt2x00_ops structure has a static field to indicate
> the extra TX headroom size required for a given device.
> The drawback of this is that we have to use a separate
> rt2x00_ops structure for each chipset which requires
> different size.
>
> Convert the static field into a callback function.
> This allows the drivers to dynamically determine the
> extra TX headroom size based on the actual chipset.
> Also implement the the callback in the drivers which
> needs an extra TX headroom, and remove the field
> initialization from the others.
>
> Additionally, introduce a new extra_tx_headroom field
> in struct rt2x00_dev, initialize its value in the probe
> routine and use the cached value in the rest of the code.
Could we rather get rid of that extra_tx_headroom variable and use queue
parameters: winfo_size and desc_size ?
Stanislaw
next prev parent reply other threads:[~2013-06-05 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 10:53 [PATCH 1/2] rt2x00: convert rt2x00_ops.extra_tx_headroom to be a fuction Gabor Juhos
2013-06-05 10:54 ` [PATCH 2/2] rt2x00: rt2800usb: nuke rt2800usb_ops_5592 Gabor Juhos
2013-06-05 12:51 ` Stanislaw Gruszka [this message]
2013-06-05 19:58 ` [PATCH 1/2] rt2x00: convert rt2x00_ops.extra_tx_headroom to be a fuction Gabor Juhos
2013-06-06 12:36 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130605125130.GA3367@redhat.com \
--to=sgruszka@redhat.com \
--cc=juhosg@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).