* [patch] cw1200: remove an unreachable goto
@ 2013-06-06 10:51 Dan Carpenter
2013-06-06 10:55 ` Solomon Peachy
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-06-06 10:51 UTC (permalink / raw)
To: Solomon Peachy; +Cc: John W. Linville, linux-wireless, kernel-janitors
The "return" is correct and the unreachable "goto" line is wrong.
I have deleted it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/cw1200/hwio.c b/drivers/net/wireless/cw1200/hwio.c
index 1af7b3d..f6b5efd 100644
--- a/drivers/net/wireless/cw1200/hwio.c
+++ b/drivers/net/wireless/cw1200/hwio.c
@@ -178,7 +178,6 @@ int cw1200_indirect_read(struct cw1200_common *priv, u32 addr, void *buf,
if ((buf_len / 2) >= 0x1000) {
pr_err("Can't read more than 0xfff words.\n");
return -EINVAL;
- goto out;
}
priv->sbus_ops->lock(priv->sbus_priv);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] cw1200: remove an unreachable goto
2013-06-06 10:51 [patch] cw1200: remove an unreachable goto Dan Carpenter
@ 2013-06-06 10:55 ` Solomon Peachy
0 siblings, 0 replies; 2+ messages in thread
From: Solomon Peachy @ 2013-06-06 10:55 UTC (permalink / raw)
To: Dan Carpenter; +Cc: John W. Linville, linux-wireless, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
On Thu, Jun 06, 2013 at 03:51:45AM -0700, Dan Carpenter wrote:
> The "return" is correct and the unreachable "goto" line is wrong.
> I have deleted it.
A patch for this was posted earlier by Joe Perches. It's in my tree
now, awaiting merging.
- Solomon
--
Solomon Peachy pizza at shaftnet dot org
Delray Beach, FL ^^ (email/xmpp) ^^
Quidquid latine dictum sit, altum viditur.
[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-06 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-06 10:51 [patch] cw1200: remove an unreachable goto Dan Carpenter
2013-06-06 10:55 ` Solomon Peachy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).