Re: [PATCH 1/2] rt2x00: convert rt2x00_ops.extra_tx_headroom to be a fuction

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Wed, Jun 05, 2013 at 09:58:10PM +0200, Gabor Juhos wrote:
> > Could we rather get rid of that extra_tx_headroom variable and use queue
> > parameters: winfo_size and desc_size ?
> 
> Yes, it seems that we can compute the value of extra_tx_headrom from those
> fields. The driver uses the following values now:
> 
> driver/device    desc_size         winfo_size           extra_tx_headroom
> 
> rt2400pci        TXD_DESC_SIZE     0                    0
> rt2500pci        TXD_DESC_SIZE     0                    0
> rt2800pci        TXD_DESC_SIZE     TXWI_DESC_SIZE       TXWI_DESC_SIZE
> rt61pci          TXD_DESC_SIZE     0                    0
> 
> rt2500usb        TXD_DESC_SIZE     0                    TXD_DESC_SIZE
> rt2800usb        TXINFO_DESC_SIZE  TXWI_DESC_SIZE       TXINFO_DESC_SIZE +
> TXWI_DESC_SIZE
> rt2800usb/RT5592 TXINFO_DESC_SIZE  TXWI_DESC_SIZE_5592  TXINFO_DESC_SIZE +
> TXWI_DESC_SIZE_5592
> rt73usb          TXD_DESC_SIZE     0                    TXD_DESC_SIZE
> 
> On USB devices we can get it from desc_size + winfo_size and on PCI/PCIe/SoC
> devices it equals with winfo_size. So the callbacks and the extra_tx_headroom
> field in rt2x00_ops can be removed.
> 
> However I would keep the new extra_tx_headroom field in rt2x00_dev. It would
> ensure that we don't have to compute its value every time it is used.

Ok, that make sense.

Thanks
Stanislaw