Linux wireless drivers development
 help / color / mirror / Atom feed
From: Samuel Ortiz <sameo@linux.intel.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Linux Wireless <linux-wireless@vger.kernel.org>,
	Linux NFC <linux-nfc@lists.01.org>
Subject: [GIT] [3.10] NFC fixes
Date: Thu, 6 Jun 2013 17:20:19 +0200	[thread overview]
Message-ID: <20130606152019.GT4793@zurbaran> (raw)

Hi John,

This is the 2nd NFC pull request for 3.10.

I wish this one could have been part of the first one, but we came back from
the NFC plugfest with a few more LLCP fixes:

- The well known services bitmask was sent with the wrong endianness and with
  the first bit not set, which goes against the LLCP specifications. This
  won't prevent most use cases and tests to pass, only picky implementations
  seem to care about the WKS correctness.

- We were ignoring RNRs and were sending our pending frames regardless. We
  should just re-queue them and send a SYMM instead.

- Non blocking LLCP connections were not handled properly as we found out
  after implementing it from neard. Applications were immediatly woken up with
  a SIGHUP and connection failed. This is fixed now, allowing us to have a
  fully asynchronous NFC userspace daemon.

Thanks in advance for pulling them in.

The following changes since commit cee6dfa25831e0daac52fc582a04a7204f886220:

  Revert "ath9k_hw: Update rx gain initval to improve rx sensitivity" (2013-06-05 10:42:29 -0400)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc-fixes.git tags/nfc-fixes-3.10-2

for you to fetch changes up to fcd335b0010aeafb6e3dfd46360778ce59e1e201:

  NFC: llcp: Fix the well known services endianness (2013-06-06 16:43:51 +0200)

----------------------------------------------------------------
Samuel Ortiz (4):
      NFC: llcp: Fix non blocking sockets connections
      NFC: llcp: Do not send pending Tx frames when the remote is not ready
      NFC: llcp: Set the LLC Link Management well known service bit
      NFC: llcp: Fix the well known services endianness

 net/nfc/llcp.h      |    1 +
 net/nfc/llcp_core.c |    8 ++++++--
 net/nfc/llcp_sock.c |    8 +++++---
 3 files changed, 12 insertions(+), 5 deletions(-)
-- 
Intel Open Source Technology Centre
http://oss.intel.com/

             reply	other threads:[~2013-06-06 15:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06 15:20 Samuel Ortiz [this message]
2013-06-12 18:22 ` [GIT] [3.10] NFC fixes John W. Linville
2013-06-13  9:02   ` Samuel Ortiz
2013-06-13 15:18     ` John W. Linville
  -- strict thread matches above, loose matches on Subject: below --
2013-05-21 23:07 Samuel Ortiz
2013-05-22 18:27 ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130606152019.GT4793@zurbaran \
    --to=sameo@linux.intel.com \
    --cc=linux-nfc@lists.01.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox