linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND] mwifiex: enable/disable tx_amsdu support via module parameter
@ 2013-06-10 22:39 Bing Zhao
  2013-06-11 16:45 ` John W. Linville
  0 siblings, 1 reply; 2+ messages in thread
From: Bing Zhao @ 2013-06-10 22:39 UTC (permalink / raw)
  To: linux-wireless
  Cc: John W. Linville, Amitkumar Karwar, Avinash Patil,
	Yogesh Ashok Powar, Nishant Sarmukadam, Frank Huang, Bing Zhao

From: Avinash Patil <patila@marvell.com>

This patch disables tx_amsdu support in mwifiex by default.
tx_amdsu support can be enabled via module parameter at load time.

Signed-off-by: Avinash Patil <patila@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
---
 drivers/net/wireless/mwifiex/wmm.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mwifiex/wmm.c b/drivers/net/wireless/mwifiex/wmm.c
index 4be3d33..944e884 100644
--- a/drivers/net/wireless/mwifiex/wmm.c
+++ b/drivers/net/wireless/mwifiex/wmm.c
@@ -37,6 +37,9 @@
 /* Offset for TOS field in the IP header */
 #define IPTOS_OFFSET 5
 
+static bool enable_tx_amsdu;
+module_param(enable_tx_amsdu, bool, 0644);
+
 /* WMM information IE */
 static const u8 wmm_info_ie[] = { WLAN_EID_VENDOR_SPECIFIC, 0x07,
 	0x00, 0x50, 0xf2, 0x02,
@@ -1233,7 +1236,7 @@ mwifiex_dequeue_tx_packet(struct mwifiex_adapter *adapter)
 				mwifiex_send_delba(priv, tid_del, ra, 1);
 			}
 		}
-		if (mwifiex_is_amsdu_allowed(priv, tid) &&
+		if (enable_tx_amsdu && mwifiex_is_amsdu_allowed(priv, tid) &&
 		    mwifiex_is_11n_aggragation_possible(priv, ptr,
 							adapter->tx_buf_size))
 			mwifiex_11n_aggregate_pkt(priv, ptr, INTF_HEADER_LEN,
-- 
1.8.2.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH RESEND] mwifiex: enable/disable tx_amsdu support via module parameter
  2013-06-10 22:39 [PATCH RESEND] mwifiex: enable/disable tx_amsdu support via module parameter Bing Zhao
@ 2013-06-11 16:45 ` John W. Linville
  0 siblings, 0 replies; 2+ messages in thread
From: John W. Linville @ 2013-06-11 16:45 UTC (permalink / raw)
  To: Bing Zhao
  Cc: linux-wireless, Amitkumar Karwar, Avinash Patil,
	Yogesh Ashok Powar, Nishant Sarmukadam, Frank Huang

I have the original for this one too...

On Mon, Jun 10, 2013 at 03:39:58PM -0700, Bing Zhao wrote:
> From: Avinash Patil <patila@marvell.com>
> 
> This patch disables tx_amsdu support in mwifiex by default.
> tx_amdsu support can be enabled via module parameter at load time.
> 
> Signed-off-by: Avinash Patil <patila@marvell.com>
> Signed-off-by: Bing Zhao <bzhao@marvell.com>
> ---
>  drivers/net/wireless/mwifiex/wmm.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mwifiex/wmm.c b/drivers/net/wireless/mwifiex/wmm.c
> index 4be3d33..944e884 100644
> --- a/drivers/net/wireless/mwifiex/wmm.c
> +++ b/drivers/net/wireless/mwifiex/wmm.c
> @@ -37,6 +37,9 @@
>  /* Offset for TOS field in the IP header */
>  #define IPTOS_OFFSET 5
>  
> +static bool enable_tx_amsdu;
> +module_param(enable_tx_amsdu, bool, 0644);
> +
>  /* WMM information IE */
>  static const u8 wmm_info_ie[] = { WLAN_EID_VENDOR_SPECIFIC, 0x07,
>  	0x00, 0x50, 0xf2, 0x02,
> @@ -1233,7 +1236,7 @@ mwifiex_dequeue_tx_packet(struct mwifiex_adapter *adapter)
>  				mwifiex_send_delba(priv, tid_del, ra, 1);
>  			}
>  		}
> -		if (mwifiex_is_amsdu_allowed(priv, tid) &&
> +		if (enable_tx_amsdu && mwifiex_is_amsdu_allowed(priv, tid) &&
>  		    mwifiex_is_11n_aggragation_possible(priv, ptr,
>  							adapter->tx_buf_size))
>  			mwifiex_11n_aggregate_pkt(priv, ptr, INTF_HEADER_LEN,
> -- 
> 1.8.2.3
> 
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-11 17:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-10 22:39 [PATCH RESEND] mwifiex: enable/disable tx_amsdu support via module parameter Bing Zhao
2013-06-11 16:45 ` John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).