From: Tony Lindgren <tony@atomide.com>
To: Luciano Coelho <coelho@ti.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/5] wlcore: use irq_flags in pdata instead of hiding it behing a quirk
Date: Tue, 25 Jun 2013 23:38:56 -0700 [thread overview]
Message-ID: <20130626063855.GN5523@atomide.com> (raw)
In-Reply-To: <1372192406-29430-3-git-send-email-coelho@ti.com>
* Luciano Coelho <coelho@ti.com> [130625 13:39]:
> The platform_quirk element in the platform data was used to change the
> way the IRQ is triggered. When set, the EDGE_IRQ quirk would change
> the irqflags used and treat edge trigger differently from the rest.
>
> Instead of hiding this irq flag setting behind the quirk, export the
> whole irq_flags element and let the board file define what to use.
> This will be more meaningful than driver-specific quirks when we
> switch to DT.
>
Acked-by: Tony Lindgren <tony@atomide.com>
> Cc: Sekhar Nori <nsekhar@ti.com>
> Signed-off-by: Luciano Coelho <coelho@ti.com>
next prev parent reply other threads:[~2013-06-26 6:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 20:33 [PATCH 0/5] wilink: add device tree support Luciano Coelho
2013-06-25 20:33 ` [PATCH 1/5] wl1251: split wl251 platform data to a separate structure Luciano Coelho
2013-06-26 6:15 ` Luciano Coelho
2013-06-26 6:37 ` Tony Lindgren
2013-06-25 20:33 ` [PATCH 2/5] wlcore: use irq_flags in pdata instead of hiding it behing a quirk Luciano Coelho
2013-06-26 6:17 ` Luciano Coelho
2013-06-26 6:38 ` Tony Lindgren [this message]
2013-06-25 20:33 ` [PATCH 3/5] wlcore: remove pwr_in_suspend from platform data Luciano Coelho
2013-06-25 20:33 ` [PATCH 4/5] wlcore: always use one-shot IRQ Luciano Coelho
2013-06-25 20:33 ` [PATCH 5/5] wlcore: add device tree support to the sdio module Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626063855.GN5523@atomide.com \
--to=tony@atomide.com \
--cc=coelho@ti.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).