From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Paul Stewart <pstew@google.com>,
"John W. Linville" <linville@tuxdriver.com>,
"Steinar H. Gunderson" <sesse@google.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v3] iwl3945: better skb management in rx path
Date: Mon, 1 Jul 2013 14:15:53 +0200 [thread overview]
Message-ID: <20130701121552.GA1747@redhat.com> (raw)
In-Reply-To: <1372431906.3301.283.camel@edumazet-glaptop>
On Fri, Jun 28, 2013 at 08:05:06AM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Steinar reported reallocations of skb->head with IPv6, leading to
> a warning in skb_try_coalesce()
>
> It turns out iwl3945 has several problems :
>
> 1) skb->truesize is underestimated.
> We really consume PAGE_SIZE bytes for a fragment,
> not the frame length.
> 2) 128 bytes of initial headroom is a bit low and forces reallocations.
> 3) We can avoid consuming a full page for small enough frames.
>
> Reported-by: Steinar H. Gunderson <sesse@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Paul Stewart <pstew@google.com>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
FYI, I'll post 4965 version soon.
prev parent reply other threads:[~2013-07-01 12:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 12:03 [PATCH] iwl3945: better skb management in rx path Eric Dumazet
2013-06-28 14:38 ` Paul Stewart
2013-06-28 14:50 ` Eric Dumazet
2013-06-28 14:59 ` Eric Dumazet
2013-06-28 15:05 ` [PATCH v3] " Eric Dumazet
2013-06-28 23:05 ` Steinar H. Gunderson
2013-07-01 12:15 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701121552.GA1747@redhat.com \
--to=sgruszka@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=pstew@google.com \
--cc=sesse@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).