* [PATCH] ath5k: fix extra set bit in multicast mask
@ 2013-07-11 13:19 Bob Copeland
0 siblings, 0 replies; only message in thread
From: Bob Copeland @ 2013-07-11 13:19 UTC (permalink / raw)
To: linux-wireless, linville; +Cc: ath5k-devel, mickflemm
Bit 32 was always set which looks to have been accidental,
according to git history.
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
Just found this while reading old code -- I could maybe see
bit 0 being special, but bit 32 seemed odd. Then looked
back through the history and looks like it was accidentally
added when prepare_multicast() was introduced; prior both
were initialized to 0.
drivers/net/wireless/ath/ath5k/mac80211-ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath5k/mac80211-ops.c b/drivers/net/wireless/ath/ath5k/mac80211-ops.c
index 06f86f4..f5f1bc7 100644
--- a/drivers/net/wireless/ath/ath5k/mac80211-ops.c
+++ b/drivers/net/wireless/ath/ath5k/mac80211-ops.c
@@ -325,7 +325,7 @@ ath5k_prepare_multicast(struct ieee80211_hw *hw,
struct netdev_hw_addr *ha;
mfilt[0] = 0;
- mfilt[1] = 1;
+ mfilt[1] = 0;
netdev_hw_addr_list_for_each(ha, mc_list) {
/* calculate XOR of eight 6-bit values */
--
1.7.10.4
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-07-11 13:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-11 13:19 [PATCH] ath5k: fix extra set bit in multicast mask Bob Copeland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).