* [patch] iwlwifi: pcie: returning positive instead of negative
@ 2013-08-10 23:03 Dan Carpenter
2013-08-12 8:11 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-08-10 23:03 UTC (permalink / raw)
To: Johannes Berg
Cc: Emmanuel Grumbach, Intel Linux Wireless, John W. Linville,
linux-wireless, kernel-janitors
There is a missing '-' character here so we return positive 'ENOMEM'
instead of negative. The caller doesn't care. All non-zero returns
are translated to '-ENOMEM' in iwl_pcie_nic_init().
This is just a cleanup.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/iwlwifi/pcie/tx.c b/drivers/net/wireless/iwlwifi/pcie/tx.c
index 134f7a1..a81d227 100644
--- a/drivers/net/wireless/iwlwifi/pcie/tx.c
+++ b/drivers/net/wireless/iwlwifi/pcie/tx.c
@@ -829,7 +829,7 @@ static int iwl_pcie_tx_alloc(struct iwl_trans *trans)
sizeof(struct iwl_txq), GFP_KERNEL);
if (!trans_pcie->txq) {
IWL_ERR(trans, "Not enough memory for txq\n");
- ret = ENOMEM;
+ ret = -ENOMEM;
goto error;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] iwlwifi: pcie: returning positive instead of negative
2013-08-10 23:03 [patch] iwlwifi: pcie: returning positive instead of negative Dan Carpenter
@ 2013-08-12 8:11 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2013-08-12 8:11 UTC (permalink / raw)
To: Dan Carpenter
Cc: Emmanuel Grumbach, Intel Linux Wireless, John W. Linville,
linux-wireless, kernel-janitors
On Sun, 2013-08-11 at 02:03 +0300, Dan Carpenter wrote:
> There is a missing '-' character here so we return positive 'ENOMEM'
> instead of negative. The caller doesn't care. All non-zero returns
> are translated to '-ENOMEM' in iwl_pcie_nic_init().
>
> This is just a cleanup.
Applied, thanks.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-12 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-10 23:03 [patch] iwlwifi: pcie: returning positive instead of negative Dan Carpenter
2013-08-12 8:11 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).