* RE: [PATCH] iwlwifi: mvm: make debugfs write() operations write up to count bytes [not found] <1376267972-5636-1-git-send-email-tixxdz@opendz.org> @ 2013-08-12 8:19 ` Berg, Johannes 2013-08-12 12:33 ` Djalal Harouni 0 siblings, 1 reply; 2+ messages in thread From: Berg, Johannes @ 2013-08-12 8:19 UTC (permalink / raw) To: Djalal Harouni, Grumbach, Emmanuel, Intel Linux Wireless, John W. Linville, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org > Some debugfs write() operations of the MVM Firmware will ignore the count > argument, and will copy more bytes than what was specified. > Fix this by getting the right count of bytes. > > This will also honor restrictions put on the number of bytes to write. That makes some sense. > To be consitant this patch also switches the initializer from 'char buf[x] = {}' to > the explicit memset() as it is done in other places of the same file. I'd rather this (a) be done in a separate patch, and (b) the other way around, switch everything to C99. > Cc: stable@vger.kernel.org That doesn't really make sense for the debugfs interface. > + memset(buf, 0, sizeof(buf)); > + if (count > sizeof(buf) - 1) > + count = sizeof(buf) - 1; Why -1? And why not use min()/min_t()? johannes -- Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iwlwifi: mvm: make debugfs write() operations write up to count bytes 2013-08-12 8:19 ` [PATCH] iwlwifi: mvm: make debugfs write() operations write up to count bytes Berg, Johannes @ 2013-08-12 12:33 ` Djalal Harouni 0 siblings, 0 replies; 2+ messages in thread From: Djalal Harouni @ 2013-08-12 12:33 UTC (permalink / raw) To: Berg, Johannes Cc: Grumbach, Emmanuel, Intel Linux Wireless, John W. Linville, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org On Mon, Aug 12, 2013 at 08:19:12AM +0000, Berg, Johannes wrote: > > Some debugfs write() operations of the MVM Firmware will ignore the count > > argument, and will copy more bytes than what was specified. > > Fix this by getting the right count of bytes. > > > > This will also honor restrictions put on the number of bytes to write. > > That makes some sense. And avoid strncmp() on garbage data. > > To be consitant this patch also switches the initializer from 'char buf[x] = {}' to > > the explicit memset() as it is done in other places of the same file. > > I'd rather this (a) be done in a separate patch, and (b) the other way around, switch everything to C99. Ok > > Cc: stable@vger.kernel.org > > That doesn't really make sense for the debugfs interface. Ok > > + memset(buf, 0, sizeof(buf)); > > + if (count > sizeof(buf) - 1) > > + count = sizeof(buf) - 1; > > Why -1? And why not use min()/min_t()? Yes -1 to be sure that the processed string is null terminated Ok will use min_t Will send a second version, Thanks! > johannes > -- > > Intel GmbH > Dornacher Strasse 1 > 85622 Feldkirchen/Muenchen, Deutschland > Sitz der Gesellschaft: Feldkirchen bei Muenchen > Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk > Registergericht: Muenchen HRB 47456 > Ust.-IdNr./VAT Registration No.: DE129385895 > Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052 > -- Djalal Harouni http://opendz.org ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-12 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1376267972-5636-1-git-send-email-tixxdz@opendz.org>
2013-08-12 8:19 ` [PATCH] iwlwifi: mvm: make debugfs write() operations write up to count bytes Berg, Johannes
2013-08-12 12:33 ` Djalal Harouni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).