Re: [PATCH] mwifiex: add missing endian conversions

["John W. Linville" <linville@tuxdriver.com>]

On Mon, Aug 26, 2013 at 12:27:06PM -0700, Bing Zhao wrote:
> Hi Tobias,
> 
> > Fixes multiple locations where a little endian host is assumed during
> > ser/des of messages sent to/received from the chip.
> 
> Thanks for your patch.
> It doesn't apply to wireless or wireless-next trees.
> 
> Which git tree are you using?

I got it to apply with a little trying.

> > 
> > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> > ---
> >  drivers/net/wireless/mwifiex/11n_aggr.c    | 2 +-
> >  drivers/net/wireless/mwifiex/main.h        | 2 +-
> >  drivers/net/wireless/mwifiex/sdio.c        | 6 +++---
> >  drivers/net/wireless/mwifiex/sta_cmdresp.c | 2 +-
> >  4 files changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/mwifiex/11n_aggr.c b/drivers/net/wireless/mwifiex/11n_aggr.c
> > index a78e065..b53c73c 100644
> > --- a/drivers/net/wireless/mwifiex/11n_aggr.c
> > +++ b/drivers/net/wireless/mwifiex/11n_aggr.c
> > @@ -69,7 +69,7 @@ mwifiex_11n_form_amsdu_pkt(struct sk_buff *skb_aggr,
> >  	memcpy(&tx_header->eth803_hdr, skb_src->data, dt_offset);
> > 
> >  	/* Copy SNAP header */
> > -	snap.snap_type = *(u16 *) ((u8 *)skb_src->data + dt_offset);
> > +	snap.snap_type = le16_to_cpu(*(__le16 *) ((u8 *)skb_src->data + dt_offset));
> 
> This line exceeds 80 characters. Please break it to two lines.

Please submit a new patch to fix this.

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.