From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Paul Menzel <paulepanter@users.sourceforge.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Fabien ADAM <id2ndr@crocobox.org>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [rt2x00-users] [PATCH 3.11 v2] rt2800: fix wrong TX power compensation
Date: Tue, 27 Aug 2013 11:13:34 +0200 [thread overview]
Message-ID: <20130827091334.GC5548@redhat.com> (raw)
In-Reply-To: <1377591967.5019.25.camel@mattotaupa>
On Tue, Aug 27, 2013 at 10:26:07AM +0200, Paul Menzel wrote:
> > /*
> > + * First check if temperature compensation is supported.
> > + */
> > + rt2x00_eeprom_read(rt2x00dev, EEPROM_NIC_CONF1, &eeprom);
> > + if (!rt2x00_get_field16(eeprom, EEPROM_NIC_CONF1_EXTERNAL_TX_ALC))
> > + return 0;
>
> Could a (debug) message be printed that temperature compensations is not
> supported? Not sure if that should be done in the library or the code
> calling this function.
This is frequent path, so it will need to be a printk_once() based
message, but perhaps would be better to print chip capabilities
coded on the EEPROM together with "Chipset detected" message on
device initialization.
Anyway, we can add debugging on separate patch.
Stanislaw
next prev parent reply other threads:[~2013-08-27 9:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 13:18 [PATCH 3.11] rt2800: fix wrong TX power compensation Stanislaw Gruszka
2013-08-26 19:04 ` [rt2x00-users] " Gertjan van Wingerde
2013-08-26 20:19 ` Paul Menzel
2013-08-27 8:00 ` Stanislaw Gruszka
2013-08-27 8:13 ` [PATCH 3.11 v2] " Stanislaw Gruszka
2013-08-27 8:26 ` [rt2x00-users] " Paul Menzel
2013-08-27 9:13 ` Stanislaw Gruszka [this message]
2013-08-28 15:10 ` John W. Linville
2013-08-27 8:22 ` [rt2x00-users] [PATCH 3.11] " Daniel Golle
2013-08-27 8:22 ` Paul Menzel
2013-08-27 9:07 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827091334.GC5548@redhat.com \
--to=sgruszka@redhat.com \
--cc=id2ndr@crocobox.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=paulepanter@users.sourceforge.net \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).