linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Add missing braces to ath10k_pci_tx_pipe_cleanup
@ 2013-09-05  3:51 Dave Jones
  2013-09-06  9:32 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2013-09-05  3:51 UTC (permalink / raw)
  To: netdev; +Cc: kvalo, linville, ath10k, linux-wireless

The indentation here implies this was meant to be a multi-statement if, but it lacks the braces.

Signed-off-by: Dave Jones <davej@fedoraproject.org>

diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 33af467..31b69d3 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -1200,7 +1200,7 @@ static void ath10k_pci_tx_pipe_cleanup(struct hif_ce_pipe_info *pipe_info)
 
 	while (ath10k_ce_cancel_send_next(ce_hdl, (void **)&netbuf,
 					  &ce_data, &nbytes, &id) == 0) {
-		if (netbuf != CE_SENDLIST_ITEM_CTXT)
+		if (netbuf != CE_SENDLIST_ITEM_CTXT) {
 			/*
 			 * Indicate the completion to higer layer to free
 			 * the buffer
@@ -1209,6 +1209,7 @@ static void ath10k_pci_tx_pipe_cleanup(struct hif_ce_pipe_info *pipe_info)
 			ar_pci->msg_callbacks_current.tx_completion(ar,
 								    netbuf,
 								    id);
+		}
 	}
 }
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add missing braces to ath10k_pci_tx_pipe_cleanup
  2013-09-05  3:51 [PATCH] Add missing braces to ath10k_pci_tx_pipe_cleanup Dave Jones
@ 2013-09-06  9:32 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2013-09-06  9:32 UTC (permalink / raw)
  To: Dave Jones; +Cc: netdev, linux-wireless, linville, ath10k

Dave Jones <davej@redhat.com> writes:

> The indentation here implies this was meant to be a multi-statement
> if, but it lacks the braces.
>
> Signed-off-by: Dave Jones <davej@fedoraproject.org>

Thanks, applied.

I added "ath10k:" to the patch title.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-06  9:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05  3:51 [PATCH] Add missing braces to ath10k_pci_tx_pipe_cleanup Dave Jones
2013-09-06  9:32 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).