From: "John W. Linville" <linville@tuxdriver.com>
To: Daniel Mack <zonque@gmail.com>
Cc: Bing Zhao <bzhao@marvell.com>,
linux-wireless@vger.kernel.org,
Sven Neumann <s.neumann@raumfeld.com>,
Andreas Fenkart <andreas.fenkart@streamunlimited.com>,
Dylan Reid <dgreid@chromium.org>,
Paul Stewart <pstew@chromium.org>,
Amitkumar Karwar <akarwar@marvell.com>
Subject: Re: [PATCH 3.12] mwifiex: fix SDIO interrupt lost issue
Date: Tue, 15 Oct 2013 12:59:38 -0400 [thread overview]
Message-ID: <20131015165938.GA7615@tuxdriver.com> (raw)
In-Reply-To: <525D1B3A.8090805@gmail.com>
On Tue, Oct 15, 2013 at 12:38:50PM +0200, Daniel Mack wrote: > On 27.09.2013 19:55, Bing Zhao wrote:
> > From: Amitkumar Karwar <akarwar@marvell.com>
> >
> > 601216e "mwifiex: process RX packets in SDIO IRQ thread directly"
> > introduced a command timeout issue which can be reproduced easily on
> > an AM33xx platform using a test application written by Daniel Mack:
> >
> > https://gist.github.com/zonque/6579314
> >
> > mwifiex_main_process() is called from both the SDIO handler and
> > the workqueue. In case an interrupt occurs right after the
> > int_status check, but before updating the mwifiex_processing flag,
> > this interrupt gets lost, resulting in a command timeout and
> > consequently a card reset.
> >
> > Let main_proc_lock protect both int_status and mwifiex_processing
> > flag. This fixes the interrupt lost issue.
>
> John, could you take this patch trough your tree?
I already did, and it is already in Dave's tree too...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2013-10-15 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 17:55 [PATCH 3.12] mwifiex: fix SDIO interrupt lost issue Bing Zhao
2013-09-27 18:55 ` Daniel Mack
[not found] ` <CAMcMvsjFurVFS2f1zCPt0uqh2gCYAvHOvos-pY=k06=ynDH=aQ@mail.gmail.com>
2013-09-28 9:46 ` Daniel Mack
2013-10-15 10:38 ` Daniel Mack
2013-10-15 16:59 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015165938.GA7615@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=akarwar@marvell.com \
--cc=andreas.fenkart@streamunlimited.com \
--cc=bzhao@marvell.com \
--cc=dgreid@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pstew@chromium.org \
--cc=s.neumann@raumfeld.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).